From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753180AbcFUGZf (ORCPT ); Tue, 21 Jun 2016 02:25:35 -0400 Received: from regular1.263xmail.com ([211.150.99.135]:34523 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751123AbcFUGZa (ORCPT ); Tue, 21 Jun 2016 02:25:30 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: richard@nod.at X-SENDER-IP: 121.15.173.1 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v9 2/4] power: reset: add reboot mode driver To: Paul Gortmaker , Krzysztof Kozlowski References: <1466404490-3315-1-git-send-email-andy.yan@rock-chips.com> <1466404696-3464-1-git-send-email-andy.yan@rock-chips.com> <5767A4C0.3080902@samsung.com> <5767A92E.5040602@rock-chips.com> <5767E22F.5030207@samsung.com> <20160620144002.GY12567@windriver.com> Cc: robh+dt@kernel.org, heiko@sntech.de, john.stultz@linaro.org, arnd@arndb.de, bjorn.andersson@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alexandre.belloni@free-electrons.com, dbaryshkov@gmail.com, sre@kernel.org, matthias.bgg@gmail.com, linux-pm@vger.kernel.org, mbrugger@suse.com, lorenzo.pieralisi@arm.com, moritz.fischer@ettus.com, richard@nod.at From: Andy Yan Message-ID: <5768DBCB.4090903@rock-chips.com> Date: Tue, 21 Jun 2016 14:16:43 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160620144002.GY12567@windriver.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul: On 2016年06月20日 22:40, Paul Gortmaker wrote: > [Re: [PATCH v9 2/4] power: reset: add reboot mode driver] On 20/06/2016 (Mon 14:31) Krzysztof Kozlowski wrote: > >> On 06/20/2016 10:28 AM, Andy Yan wrote: >>> Hi Krzysztof: >>> >>> On 2016年06月20日 16:09, Krzysztof Kozlowski wrote: >>>> On 06/20/2016 08:38 AM, Andy Yan wrote: > [...] > >>>>> + >>>>> +config SYSCON_REBOOT_MODE >>>>> + bool "Generic SYSCON regmap reboot mode driver" >>>> Why not tristate? >>> I see many reset drivers in this directories use bool, so I follow >>> them. > Andy - understood, but mistakes done in the past do not justify > repeating them again in the present. OK, this is not strictly a mistake > in that it causes an error, but it isn't an ideal approach. > >> +Cc Paul, >> >> I don't mind that although I don't see any particular objections for >> making it module-capable. In the same time I just reminded myself about >> Paul Gortmaker's long effort (like [1] [2]) about removing module >> capability from non-modular drivers. > Thanks -- it is nice to see that people are starting to add this to > their review checklist ; early on they were getting added faster than I > could remove them. :-( But I think we are making ground now. > > For this case, I don't have any bias for it being built-in vs. being > modular, so long as the code is actually consistent with the Kconfig. > > For existing bool settings I just remove the modular references, since I > can't be extending the functionality to include a modular usage when I > can't test it or even be sure if a module has a sensible use case. > > Paul. > -- I will remove the module related stuff in the next version. >> Following his rationale, I think either this should be a tristate or the >> module stuff should be removed. >> >> Best regards, >> Krzysztof >> >> [1] https://lkml.org/lkml/2016/2/21/180 >> [2] https://lkml.org/lkml/2016/6/13/682 >> >> > >