From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751839AbcFUJe3 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 21 Jun 2016 05:34:29 -0400
Received: from mailout1.w1.samsung.com ([210.118.77.11]:60146 "EHLO
	mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751084AbcFUJdU (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 21 Jun 2016 05:33:20 -0400
X-AuditID: cbfec7f4-f796c6d000001486-a9-576909c56171
Subject: Re: [PATCH v9 2/4] power: reset: add reboot mode driver
To: Andy Yan <andy.yan@rock-chips.com>,
        Paul Gortmaker <paul.gortmaker@windriver.com>
References: <1466404490-3315-1-git-send-email-andy.yan@rock-chips.com>
 <1466404696-3464-1-git-send-email-andy.yan@rock-chips.com>
 <5767A4C0.3080902@samsung.com> <5767A92E.5040602@rock-chips.com>
 <5767E22F.5030207@samsung.com> <20160620144002.GY12567@windriver.com>
 <5768DBCB.4090903@rock-chips.com>
Cc: robh+dt@kernel.org, heiko@sntech.de, john.stultz@linaro.org, arnd@arndb.de,
        bjorn.andersson@linaro.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, alexandre.belloni@free-electrons.com,
        dbaryshkov@gmail.com, sre@kernel.org, matthias.bgg@gmail.com,
        linux-pm@vger.kernel.org, mbrugger@suse.com, lorenzo.pieralisi@arm.com,
        moritz.fischer@ettus.com, richard@nod.at
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Message-id: <576909C3.4010109@samsung.com>
Date: Tue, 21 Jun 2016 11:32:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-version: 1.0
In-reply-to: <5768DBCB.4090903@rock-chips.com>
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLIsWRmVeSWpSXmKPExsVy+t/xq7pHOTPDDaYuk7HouLaYyaL//E1G
	i7+TjrFbnN7/jsVi0pP3zBbzj5xjtfj/6DWrxZnfuhavXxhaXN41h83ic+8RRos3v1+wWzS1
	GFssmPwEKN8QYXFt73Fmi8k73zBatO49AjRmd4mDsMeaeWsYPX7/msToMfPUFnaPJ5suMnrs
	nHWX3WPTqk42jzvX9rB53JxX6PF31n4Wj74tqxg9tl+bx+yxfstVFo/Pm+SAjK1MAXxRXDYp
	qTmZZalF+nYJXBkPDx1kLfjFVPHl6EvmBsbVTF2MnBwSAiYST84fgrLFJC7cW8/WxcjFISSw
	lFHi5+TDYAkhgWeMEn/uhYPYwgIOEmsb1jCD2CIC4RJPV/+GatjEJPH62WFGEIdZoIVZYvKP
	RhaQKjYBY4nNy5cAVXFw8ApoSdzrNQUJswioSrQ/ng+2QFQgQmLW9h9gNq+AoMSPyffAWjkF
	9CTmPnvKCNLKLKAuMWVKLkiYWUBeYvOat8wTGAVmIemYhVA1C0nVAkbmVYyiqaXJBcVJ6bmG
	esWJucWleel6yfm5mxghkfplB+PiY1aHGAU4GJV4eBX0M8KFWBPLiitzDzFKcDArifBasWeG
	C/GmJFZWpRblxxeV5qQWH2KU5mBREuedu+t9iJBAemJJanZqakFqEUyWiYNTqoFRbMaSXf/2
	9Cvvrc6etHWCtnuQudu7I24p86b0dqU/CZ+gnK/D7aZ6enmUMFO095wZBY67Wf+7y3jJL9qn
	JhRWcHqVm4DFkfxJx64alDzdrBBY+vb+RqUPEa4XNP/6LPwW9L3hy0/3XQZX5xfvctlStX/j
	NlurqYab/p2yj5x87TJfSCuf1MpjSizFGYmGWsxFxYkAouG77tACAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/21/2016 08:16 AM, Andy Yan wrote:
>   I will remove the module related stuff in the next version.
>>> Following his rationale, I think either this should be a tristate or the
>>> module stuff should be removed.

How about making it tristate? I think there isn't any obstacles for this
driver being a module. Some distros like modules.

Best regards.
Krzysztof