From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752027AbcFUKUs (ORCPT ); Tue, 21 Jun 2016 06:20:48 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:46706 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751721AbcFUKUo (ORCPT ); Tue, 21 Jun 2016 06:20:44 -0400 Subject: Re: [PATCH] regulator: lp873x: Drop _nlr parameter from LP873X_REGULATOR() To: Axel Lin , Mark Brown References: <1466492351.923.1.camel@ingics.com> CC: Keerthy , Liam Girdwood , From: Keerthy Message-ID: <576913FC.1060603@ti.com> Date: Tue, 21 Jun 2016 15:46:28 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1466492351.923.1.camel@ingics.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 21 June 2016 12:29 PM, Axel Lin wrote: > No need to pass _nlr to LP873X_REGULATOR(), use ARRAY_SIZE to calculate it. Looks good to me. Acked-by: Keerthy > > Signed-off-by: Axel Lin > --- > drivers/regulator/lp873x-regulator.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/regulator/lp873x-regulator.c b/drivers/regulator/lp873x-regulator.c > index b4ffd11..e504b91 100644 > --- a/drivers/regulator/lp873x-regulator.c > +++ b/drivers/regulator/lp873x-regulator.c > @@ -20,7 +20,7 @@ > #include > > #define LP873X_REGULATOR(_name, _id, _of, _ops, _n, _vr, _vm, _er, _em, \ > - _delay, _lr, _nlr, _cr) \ > + _delay, _lr, _cr) \ > [_id] = { \ > .desc = { \ > .name = _name, \ > @@ -37,7 +37,7 @@ > .enable_mask = _em, \ > .ramp_delay = _delay, \ > .linear_ranges = _lr, \ > - .n_linear_ranges = _nlr, \ > + .n_linear_ranges = ARRAY_SIZE(_lr), \ > }, \ > .ctrl2_reg = _cr, \ > } > @@ -175,22 +175,20 @@ static const struct lp873x_regulator regulators[] = { > 256, LP873X_REG_BUCK0_VOUT, > LP873X_BUCK0_VOUT_BUCK0_VSET, LP873X_REG_BUCK0_CTRL_1, > LP873X_BUCK0_CTRL_1_BUCK0_EN, 10000, > - buck0_buck1_ranges, 4, LP873X_REG_BUCK0_CTRL_2), > + buck0_buck1_ranges, LP873X_REG_BUCK0_CTRL_2), > LP873X_REGULATOR("BUCK1", LP873X_BUCK_1, "buck1", lp873x_buck01_ops, > 256, LP873X_REG_BUCK1_VOUT, > LP873X_BUCK1_VOUT_BUCK1_VSET, LP873X_REG_BUCK1_CTRL_1, > LP873X_BUCK1_CTRL_1_BUCK1_EN, 10000, > - buck0_buck1_ranges, 4, LP873X_REG_BUCK1_CTRL_2), > + buck0_buck1_ranges, LP873X_REG_BUCK1_CTRL_2), > LP873X_REGULATOR("LDO0", LP873X_LDO_0, "ldo0", lp873x_ldo01_ops, 26, > LP873X_REG_LDO0_VOUT, LP873X_LDO0_VOUT_LDO0_VSET, > LP873X_REG_LDO0_CTRL, > - LP873X_LDO0_CTRL_LDO0_EN, 0, ldo0_ldo1_ranges, 1, > - 0xFF), > + LP873X_LDO0_CTRL_LDO0_EN, 0, ldo0_ldo1_ranges, 0xFF), > LP873X_REGULATOR("LDO1", LP873X_LDO_1, "ldo1", lp873x_ldo01_ops, 26, > LP873X_REG_LDO1_VOUT, LP873X_LDO1_VOUT_LDO1_VSET, > LP873X_REG_LDO1_CTRL, > - LP873X_LDO1_CTRL_LDO1_EN, 0, ldo0_ldo1_ranges, 1, > - 0xFF), > + LP873X_LDO1_CTRL_LDO1_EN, 0, ldo0_ldo1_ranges, 0xFF), > }; > > static int lp873x_regulator_probe(struct platform_device *pdev) >