From: Marc Zyngier <marc.zyngier@arm.com>
To: Jiancheng Xue <xuejiancheng@hisilicon.com>,
tglx@linutronix.de, jason@lakedaemon.net, majun258@huawei.com
Cc: linux-kernel@vger.kernel.org, yanhaifeng@hisilicon.com
Subject: Re: [PATCH] irqchip: fix the config HISILICON_IRQ_MBIGEN dependency error.
Date: Tue, 21 Jun 2016 11:36:02 +0100 [thread overview]
Message-ID: <57691892.70502@arm.com> (raw)
In-Reply-To: <1466501188-3948-1-git-send-email-xuejiancheng@hisilicon.com>
On 21/06/16 10:26, Jiancheng Xue wrote:
> This patch fixes the compiling error caused when
> config HISILICON_IRQ_MBIGEN is selected but
> PCI_MSI is not seleted.
>
> Signed-off-by: Jiancheng Xue <xuejiancheng@hisilicon.com>
> ---
> drivers/irqchip/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index fa33c50..23dcf3e 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -110,7 +110,7 @@ config DW_APB_ICTL
> config HISILICON_IRQ_MBIGEN
> bool
> select ARM_GIC_V3
> - select ARM_GIC_V3_ITS
> + select ARM_GIC_V3_ITS if PCI_MSI
> select GENERIC_MSI_IRQ_DOMAIN
How can this be correct? The MBIGEN uses platform MSI (not PCI) and
relies on the ITS (it doesn't work without it). It seems that you're
papering over another issue.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2016-06-21 10:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 9:26 [PATCH] irqchip: fix the config HISILICON_IRQ_MBIGEN dependency error Jiancheng Xue
2016-06-21 10:36 ` Marc Zyngier [this message]
2016-06-21 11:30 ` Jiancheng Xue
2016-06-21 12:01 ` Jiancheng Xue
2016-06-21 12:49 ` Marc Zyngier
2016-06-23 8:53 ` Jiancheng Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57691892.70502@arm.com \
--to=marc.zyngier@arm.com \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=majun258@huawei.com \
--cc=tglx@linutronix.de \
--cc=xuejiancheng@hisilicon.com \
--cc=yanhaifeng@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox