From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751694AbcFUKhk (ORCPT ); Tue, 21 Jun 2016 06:37:40 -0400 Received: from foss.arm.com ([217.140.101.70]:39396 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751730AbcFUKgF (ORCPT ); Tue, 21 Jun 2016 06:36:05 -0400 Subject: Re: [PATCH] irqchip: fix the config HISILICON_IRQ_MBIGEN dependency error. To: Jiancheng Xue , tglx@linutronix.de, jason@lakedaemon.net, majun258@huawei.com References: <1466501188-3948-1-git-send-email-xuejiancheng@hisilicon.com> Cc: linux-kernel@vger.kernel.org, yanhaifeng@hisilicon.com From: Marc Zyngier X-Enigmail-Draft-Status: N1110 Organization: ARM Ltd Message-ID: <57691892.70502@arm.com> Date: Tue, 21 Jun 2016 11:36:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.7.0 MIME-Version: 1.0 In-Reply-To: <1466501188-3948-1-git-send-email-xuejiancheng@hisilicon.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/06/16 10:26, Jiancheng Xue wrote: > This patch fixes the compiling error caused when > config HISILICON_IRQ_MBIGEN is selected but > PCI_MSI is not seleted. > > Signed-off-by: Jiancheng Xue > --- > drivers/irqchip/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > index fa33c50..23dcf3e 100644 > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig > @@ -110,7 +110,7 @@ config DW_APB_ICTL > config HISILICON_IRQ_MBIGEN > bool > select ARM_GIC_V3 > - select ARM_GIC_V3_ITS > + select ARM_GIC_V3_ITS if PCI_MSI > select GENERIC_MSI_IRQ_DOMAIN How can this be correct? The MBIGEN uses platform MSI (not PCI) and relies on the ITS (it doesn't work without it). It seems that you're papering over another issue. Thanks, M. -- Jazz is not dead. It just smells funny...