From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751789AbcFULjy (ORCPT ); Tue, 21 Jun 2016 07:39:54 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:62243 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751709AbcFULjv (ORCPT ); Tue, 21 Jun 2016 07:39:51 -0400 X-AuditID: cbfec7f5-f792a6d000001302-a5-576927835ca1 Subject: Re: [PATCH v6 2/4] power: reset: add reboot mode driver To: Andy Yan References: <1458646525-491-1-git-send-email-andy.yan@rock-chips.com> <1458646642-591-1-git-send-email-andy.yan@rock-chips.com> <57691E92.5090205@rock-chips.com> Cc: robh+dt@kernel.org, sre@kernel.org, heiko@sntech.de, john.stultz@linaro.org, arnd@arndb.de, galak@codeaurora.org, ijc+devicetree@hellion.org.uk, catalin.marinas@arm.com, olof@lixom.net, alexandre.belloni@free-electrons.com, dbaryshkov@gmail.com, jun.nie@linaro.org, pawel.moll@arm.com, will.deacon@arm.com, linux-rockchip@lists.infradead.org, matthias.bgg@gmail.com, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, f.fainelli@gmail.com, linux@arm.linux.org.uk, mbrugger@suse.com, linux-arm-kernel@lists.infradead.org, lorenzo.pieralisi@arm.com, moritz.fischer@ettus.com, linux-kernel@vger.kernel.org, wxt@rock-chips.com, dwmw2@infradead.org, mark.rutland@arm.com From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <57692781.4070506@samsung.com> Date: Tue, 21 Jun 2016 13:39:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <57691E92.5090205@rock-chips.com> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0iTYRTHefZeXU1fl+aTmcKstOElL8RDlPkh4g2CJARFAl36oqZT2Zxp KIqal+WtKaQjzHRe04QpWZaUU0xULJkpQxNvieVK0iyvmXNEfvv/z/md/zkfDo0J8wl7Ojou kZPFSWJFJB8f/PNO757tEh10dscB5Y3V8FDxewNAO6o+Ci3XFQCkml/G0OPeYQI9aCzF0Ob3 XgoVG58QaHd2iUDDXxsBGtpyR5r5GQotLXoh7dwYgfSdj0i0WtgL0Mr0LoYm9AJk3FqkUO34 CA9lZvugqtJ5Ag1lBKOB8VUSlTxswdG9rr3kwVeJ6MuPfhzlZtXx/B3Z5spmwGZnFZDs1qYK sPqiQh5bMdBOsfPaEcC+VH+i2Mb6nyTb1iBmtU35JDs59nrPadLZ0f5Mgt1Rv8HZovYmwHaM VWIBwhD+hQguNjqJk3n6hfGjiibKyQQdndxZv0tlACWlBDQNGV+oNVxUAos9eRR+mGollYBP C5laAMerhwmzWQAwv2GWMFFHGH+4MlrNM2kb5jTcMBhwM2QEcE69s28wpp2Akxt5wESRjA9s q9eQ5h2OsPC+CjdpASOGm4bf+6k4cwp+bJ2jTNqWCYbqjnWembGG66VT+7wF4wF7OvN4prMx xgWWlUlNZYxxgm3N37ASYK0+MKH+T6kPUFUAawK2nCI8QX4rUurtIZdI5Yq4SI/weKkWmB9k 7QWo7TuvAwwNRIcFyV5RQUJCkiRPkeoApDGRjSDHOTpIKIiQpNzlZPGhMkUsJ9eB4zQushNU dC4HCplISSIXw3EJnOxfl0db2GeAqG47Wc+Wmyt/2qr9ectn0D1upaBP+NRragLd7lgOh3nc vNats0qjQlK73tLFkapjRmfXtOsCg92ziMqZRH/lou9lAeNytSl902j0yxblLiq2QzG9i2eM 5Wi5w4b3Db+nJwMmqtfE4gX8XFFuquaQ95UzHQ1M1y+nS57bits5IlweJfESYzK55C+HxlMx HAMAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/21/2016 01:01 PM, Andy Yan wrote: (...) >>> +MODULE_AUTHOR("Andy Yan >> +MODULE_DESCRIPTION("System reboot mode driver"); >>> +MODULE_LICENSE("GPL v2"); >>> diff --git a/drivers/power/reset/reboot-mode.h >>> b/drivers/power/reset/reboot-mode.h >>> new file mode 100644 >>> index 0000000..44ed34f >>> --- /dev/null >>> +++ b/drivers/power/reset/reboot-mode.h >>> @@ -0,0 +1,6 @@ >>> +#ifndef __REBOOT_MODE_H__ >>> +#define __REBOOT_MODE_H__ >>> + >>> +int reboot_mode_register(struct device *dev, int (*write)(int)); >> Documentation would be appreciated. Although it is local header but >> you decoupled them and you are exporting the function. > > You want this driver being a module in V9, so you may also want > I document this function when a exporting it. Where I should write the > documentation, and would you please give me some example? Follow kernel-doc (kernel-doc-nano-HOWTO.txt). There is an example. Put the documentation of functions next to them in source file (not header). Best regards, Krzysztof