From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752316AbcFUL7t (ORCPT <rfc822;w@1wt.eu>);
	Tue, 21 Jun 2016 07:59:49 -0400
Received: from szxga05-in.huawei.com ([58.251.152.179]:11347 "EHLO
	szxga05-in.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
	with ESMTP id S1751568AbcFUL7s (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 21 Jun 2016 07:59:48 -0400
Subject: Re: [PATCH 19/27] [AARCH64] Add typesizes.h for ILP32
To: Andreas Schwab <schwab@suse.de>, Yury Norov <ynorov@caviumnetworks.com>
References: <1466485631-3532-1-git-send-email-ynorov@caviumnetworks.com>
 <1466485631-3532-21-git-send-email-ynorov@caviumnetworks.com>
 <mvmh9cnrn10.fsf@hawking.suse.de>
CC: <libc-alpha@sourceware.org>, <linux-kernel@vger.kernel.org>,
        <arnd@arndb.de>, <catalin.marinas@arm.com>, <marcus.shawcroft@arm.com>,
        <philb@gnu.org>, <davem@davemloft.net>, <szabolcs.nagy@arm.com>,
        <maxim.kuvyrkov@linaro.org>, <joseph@codesourcery.com>,
        <pinskia@gmail.com>, Andrew Pinski <apinski@cavium.com>,
        <gaoyongliang@huawei.com>,
        "Zhangjian (Bamvor)" <bamvor.zhangjian@huawei.com>
From: "Zhangjian (Bamvor)" <bamvor.zhangjian@huawei.com>
Message-ID: <57692C1F.8050309@huawei.com>
Date: Tue, 21 Jun 2016 19:59:27 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <mvmh9cnrn10.fsf@hawking.suse.de>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.111.72.170]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020205.57692C31.00B7,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2014-11-16 11:51:01,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 7aec0a383a36d12841b7d910192e7f64
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 2016/6/21 15:58, Andreas Schwab wrote:
> Yury Norov <ynorov@caviumnetworks.com> writes:
>
>> diff --git a/sysdeps/unix/sysv/linux/sysdep-vdso.h b/sysdeps/unix/sysv/linux/sysdep-vdso.h
>> index e8c4a7b..351d6bb 100644
>> --- a/sysdeps/unix/sysv/linux/sysdep-vdso.h
>> +++ b/sysdeps/unix/sysv/linux/sysdep-vdso.h
>> @@ -37,7 +37,7 @@
>>       __label__ out;							      \
>>       __label__ iserr;							      \
>>       INTERNAL_SYSCALL_DECL (sc_err);					      \
>> -    long int sc_ret;							      \
>> +    __syscall_slong_t sc_ret;						      \
>>   									      \
>>       __typeof (__vdso_##name) vdsop = __vdso_##name;			      \
>>       PTR_DEMANGLE (vdsop);						      \
>> @@ -64,7 +64,7 @@
>>   #  define INTERNAL_VSYSCALL(name, err, nr, args...)			      \
>>     ({									      \
>>       __label__ out;							      \
>> -    long v_ret;								      \
>> +    __syscall_slong_t v_ret;						      \
>>   									      \
>>       __typeof (__vdso_##name) vdsop = __vdso_##name;			      \
>>       PTR_DEMANGLE (vdsop);						      \
>
> That part should have no effect now that __SYSCALL_SLONG_TYPE remains to
> be long.
Agree. According to the discussion in "[PATCH 11/27] [AARCH64] Syscalls for ILP32 are passed
always via 64bit values.". We should update this to long long too.

Regard

Bamvor
>
> Andreas.
>