Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S.

Yury Norov
2016-06-22T06:02:42Z

On Tue, Jun 21, 2016 at 10:28:40AM +0000, Joseph Myers wrote:
> On Tue, 21 Jun 2016, Yury Norov wrote:
>
> > +#ifdef __LP64__
> > +#define RTLD_START RTLD_START_1("x", "3", "sp")
> > +#else
> > +#define RTLD_START RTLD_START_1("w", "2", "wsp")
> > +#endif
>
> As well as preprocessor indentation, this is missing spaces after '(';
> check for and fix that issue throughout this patch series. (There are
> only a few cases where a macro is used to construct a type / variable
> name, such as ElfW, where missing the space is more usual.)
>
> --
> Joseph S. Myers
> joseph@codesourcery.com

So, you want have it like this?
#ifdef __LP64__
# define RTLD_START RTLD_START_1( "x", "3", "sp" )
#else
# define RTLD_START RTLD_START_1( "w", "2", "wsp" )
#endif

Pretty contr-intuitive to me...
Anyway, I follow it.