Re: [PATCH 23/27] [AARCH64] delouse input arguments in system functions

Arnd Bergmann
2016-06-21T15:40:56Z

On Tuesday, June 21, 2016 10:36:53 AM CEST Joseph Myers wrote:
> On Tue, 21 Jun 2016, Yury Norov wrote:
>
> > Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
>
> You're missing a patch description. What does "delouse" even mean? What
> is the ABI peculiarity that means there are ABI-conforming arguments to
> these functions that need such a manipulation?
>

This is the term the kernel uses for making sure that no system call
from user space passes data in the upper bits of the argument registers,
which could end up being used in an exploit when the calling conventions
between functions assume that the upper bits contain zeroes.

I don't think there is any point in doing this in glibc though: we
can safely assume that any application calling into glibc follows
the documented calling conventions (it would otherwise be a bug),
but the kernel still has to zero those registers because malicious
user space code would simply execute the system call instruction
directly instead of calling into glibc...

Arnd