Re: [PATCH 21/27] [AARCH64] ILP32: introduce syscalls that pass off_t

Joseph Myers
2016-06-23T11:57:53Z

On Thu, 23 Jun 2016, Yury Norov wrote:

> So for now I think it's simpler to have this ABI in sysdeps, and be in

Of course it goes in sysdeps. But not architecture-specific sysdeps.
And "simpler" for initial implementation may not be simpler for future
maintenance; when there are too many implementations of a function, they
have a tendency to get out of sync, and to cause trouble for future global
changes. There are two plausible options that I see:

* sysdeps/unix/sysv/linux/<some-descriptive-name>, where
<some-descriptive-name> is an architecture-independent name for the
relevant ABI feature.

* Have a macro __SOME_ABI_FEATURE in some sysdeps header, and then use
conditionals on that macro in existing implementations in
sysdeps/unix/sysv/linux/generic or sysdeps/unix/sysv/linux.

I think the second one is preferable. If you prefer the first one, you
should be able to justify it by giving some detailed examples of what the
different implementations look like and why there is actually nothing
useful in common between them that would allow shared implementations with
conditional code.

--
Joseph S. Myers
joseph@codesourcery.com