Re: [PATCH 23/27] [AARCH64] delouse input arguments in system functions

Andreas Schwab
2016-06-21T08:24:11Z

Yury Norov <ynorov@caviumnetworks.com> writes:

> diff --git a/sysdeps/aarch64/dl-tlsdesc.S b/sysdeps/aarch64/dl-tlsdesc.S
> index fe8a17d..718dddf 100644
> --- a/sysdeps/aarch64/dl-tlsdesc.S
> +++ b/sysdeps/aarch64/dl-tlsdesc.S
> @@ -74,6 +74,7 @@
> cfi_startproc
> .align 2
> _dl_tlsdesc_return:
> + DELOUSE(0)
> ldr PTR_REG (0), [x0, #PTR_SIZE]
> RET
> cfi_endproc
> @@ -126,6 +127,7 @@ _dl_tlsdesc_undefweak:
> td->entry in _dl_tlsdesc_resolve_rela_fixup ensuring that the load
> from [x0,#8] here happens after the initialization of td->arg. */
> ldar xzr, [x0]
> + DELOUSE(0)

That needs to be moved before the previous insn, doesn't it? Also,
again _dl_tlsdesc_return_lazy is missing.

Andreas.

--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."