Re: [PATCH 11/27] [AARCH64] Syscalls for ILP32 are passed always via 64bit values.

Andreas Schwab
2016-06-21T12:13:48Z

"Zhangjian (Bamvor)" <bamvor.zhangjian@huawei.com> writes:

> Hi,
>
> On 2016/6/21 15:56, Andreas Schwab wrote:
>> Yury Norov <ynorov@caviumnetworks.com> writes:
>>
>>> diff --git a/sysdeps/unix/sysv/linux/aarch64/sysdep.h b/sysdeps/unix/sysv/linux/aarch64/sysdep.h
>>> index 1ffabc2..42f89c8 100644
>>> --- a/sysdeps/unix/sysv/linux/aarch64/sysdep.h
>>> +++ b/sysdeps/unix/sysv/linux/aarch64/sysdep.h
>>> @@ -161,11 +161,11 @@
>>> call. */
>>> # undef INLINE_SYSCALL
>>> # define INLINE_SYSCALL(name, nr, args...) \
>>> - ({ unsigned long _sys_result = INTERNAL_SYSCALL (name, , nr, args); \
>>> + ({ unsigned long long _sys_result = INTERNAL_SYSCALL (name, , nr, args); \
>>> if (__builtin_expect (INTERNAL_SYSCALL_ERROR_P (_sys_result, ), 0))\
>>> { \
>>> __set_errno (INTERNAL_SYSCALL_ERRNO (_sys_result, )); \
>>> - _sys_result = (unsigned long) -1; \
>>> + _sys_result = (unsigned long long) -1; \
>>> } \
>>> (long) _sys_result; })
>>
>> The cast should be (long long).
> My understanding that we need more conversion, reference the follow patch:

And this:

diff --git a/sysdeps/unix/sysv/linux/aarch64/sysdep.c b/sysdeps/unix/sysv/linux/aarch64/sysdep.c
index f2d5480..1bec443 100644
--- a/sysdeps/unix/sysv/linux/aarch64/sysdep.c
+++ b/sysdeps/unix/sysv/linux/aarch64/sysdep.c
@@ -19,13 +19,13 @@
#include <sysdep.h>
#include <errno.h>

-long __syscall_error (long err);
+long long __syscall_error (long long err);
hidden_proto (__syscall_error)

/* This routine is jumped to by all the syscall handlers, to stash
an error number into errno. */
-long
-__syscall_error (long err)
+long long
+__syscall_error (long long err)
{
__set_errno (- err);
return -1;

Andreas.

--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."