From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751752AbcFUNYQ (ORCPT ); Tue, 21 Jun 2016 09:24:16 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:35562 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750696AbcFUNYO (ORCPT ); Tue, 21 Jun 2016 09:24:14 -0400 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: borntraeger@de.ibm.com X-IBM-RcptTo: kvm@vger.kernel.org;linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] x86/entry: speed up context-tracking system calls by 150 clock cycles To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <1466434712-31440-1-git-send-email-pbonzini@redhat.com> Cc: Andy Lutomirski , Peter Zijlstra , Rik van Riel , "H . Peter Anvin" , Ingo Molnar , Thomas Gleixner From: Christian Borntraeger Date: Tue, 21 Jun 2016 15:24:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1466434712-31440-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16062113-0016-0000-0000-000001FD05D8 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16062113-0017-0000-0000-00002201526B Message-Id: <57693FF7.3050103@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-21_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606210154 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/20/2016 04:58 PM, Paolo Bonzini wrote: > The first patches are the two optimizations I posted on May 30th > for the system call entry/exit code. The only change is in the > function names, which use the user_{enter,exit}_irqoff favored > by Andy and Ingo. The first patch matches what commit d0e536d8939 > ("context_tracking: avoid irq_save/irq_restore on guest entry and exit", > 2015-10-28) did for guest entry and exit. The second simply adds > an inline annotation; the compiler doesn't figure it out because the > function is not static. > > The second two patches move guest_{enter,exit} to the same naming > convention, removing the KVM wrappers kvm_guest_{enter,exit} and > __kvm_guest_{enter,exit} in the process. I would like these two to > go through the KVM tree because I have other optimizations for 4.8 > on top of these patches. > > Thanks, > > Paolo > > Paolo Bonzini (4): > x86/entry: Avoid interrupt flag save and restore > x86/entry: Inline enter_from_user_mode > context_tracking: move rcu_virt_note_context_switch out of kvm_host.h > KVM: remove kvm_guest_enter/exit wrappers > > arch/arm/kvm/arm.c | 8 +++--- > arch/mips/kvm/mips.c | 4 +-- > arch/powerpc/kvm/book3s_hv.c | 4 +-- > arch/powerpc/kvm/book3s_pr.c | 4 +-- > arch/powerpc/kvm/booke.c | 4 +-- > arch/powerpc/kvm/powerpc.c | 2 +- > arch/s390/kvm/kvm-s390.c | 4 +-- > arch/x86/entry/common.c | 6 ++--- > arch/x86/kvm/x86.c | 4 +-- > include/linux/context_tracking.h | 53 +++++++++++++++++++++++++++++++++++++--- > include/linux/kvm_host.h | 39 ----------------------------- > 11 files changed, 69 insertions(+), 63 deletions(-) > Series looks sane and does work on s390. It has a minor conflict with my vsie pull request (so either add vsie.c to this patch set or fixup my pull request in the merge commit to replace kvm_guest_exit/enter with the new functions. Christian