From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752157AbcFUPjj (ORCPT ); Tue, 21 Jun 2016 11:39:39 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:50052 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751209AbcFUPjd (ORCPT ); Tue, 21 Jun 2016 11:39:33 -0400 X-AuditID: cbfec7f4-f796c6d000001486-6c-57695d032f5a Message-id: <57695D02.2000109@samsung.com> Date: Tue, 21 Jun 2016 17:28:02 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Florian Vaussard Cc: devicetree@vger.kernel.org, Richard Purdie , Rob Herring , Mark Rutland , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Florian Vaussard Subject: Re: [PATCH 1/2] leds: ncp5623: Add device tree binding documentation References: <1466494154-3786-1-git-send-email-florian.vaussard@heig-vd.ch> <1466494154-3786-2-git-send-email-florian.vaussard@heig-vd.ch> In-reply-to: <1466494154-3786-2-git-send-email-florian.vaussard@heig-vd.ch> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCLMWRmVeSWpSXmKPExsVy+t/xq7rMsZnhBlN/qFrMP3KO1WLyocXs Fq+2W1tc3jWHzWLrm3WMFkuvX2SyaN17hN1i966nrA4cHmvmrWH02DnrLrvH03X9LB6bVnWy eeyZ/4PV4/MmuQC2KC6blNSczLLUIn27BK6M5qmaBf9FK15Mf8rcwLhGsIuRg0NCwERi7dTU LkZOIFNM4sK99WxdjFwcQgJLGSXuXzjGDuE8Y5SYteEpM0gVr4CWxNMpG9lAmlkEVCVenk4A CbMJGEr8fPGaCcQWFYiQ+HN6HytEuaDEj8n3WEBsEaCaxreHwWYyC/xklNg0+RpYkbCAr8TH 90uYIZZ1M0pcuL4VrINTwFti/6JGsCJmAWuJlZO2MULY8hKb17xlnsAoMAvJkllIymYhKVvA yLyKUTS1NLmgOCk911CvODG3uDQvXS85P3cTIyTsv+xgXHzM6hCjAAejEg+vgn5GuBBrYllx Ze4hRgkOZiUR3qDwzHAh3pTEyqrUovz4otKc1OJDjNIcLErivHN3vQ8REkhPLEnNTk0tSC2C yTJxcEo1MPoXv7qxwXB/sc6R+Y7uutIsC2r1Ki9Oaei6nZXHffvatKuuHakbpGaYv3JYYVSj PUvee/b/Yp4j+qqZAbP/Wuw5cSRmf6NlX5HhJ+11mWHujD6zP8TPKNlyn+fxpSwua/6OqIKw ZV95mqraNU3Tkxz6rup+X5PO7XNtlm9HmFrSgqQbqmmTlViKMxINtZiLihMBnszUxHcCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Florian, Thanks for the patch. I have two remarks below. On 06/21/2016 09:29 AM, Florian Vaussard wrote: > Add device tree binding documentation for On Semiconductor NCP5623 I2C > LED driver. The driver can independently control the PWM of the 3 > channels with 32 levels of intensity. > > The current delivered by the current source can be controlled using the > led-max-microamp property. In order to control this value, it is also > necessary to know the current on the Iref pin, hence the > onnn,led-iref-microamp property. It is usually set using an external > bias resistor, following Iref = Vref/Rbias with Vref=0.6V. > > Signed-off-by: Florian Vaussard > --- > .../devicetree/bindings/leds/leds-ncp5623.txt | 44 ++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-ncp5623.txt > > diff --git a/Documentation/devicetree/bindings/leds/leds-ncp5623.txt b/Documentation/devicetree/bindings/leds/leds-ncp5623.txt > new file mode 100644 > index 0000000..0dc8345 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-ncp5623.txt > @@ -0,0 +1,44 @@ > +* ON Semiconductor - NCP5623 3-Channel LED Driver > + > +The NCP5623 is a 3-channel I2C LED driver. The brightness of each > +channel can be independently set using 32 levels. Each LED is represented > +as a sub-node of the device. > + > +Required properties: > + - compatible: Should be "onnn,ncp5623" > + - reg: I2C slave address (fixed to 0x38) > + - #address-cells: must be 1 > + - #size-cells: must be 0 > + - onnn,led-iref-microamp: Current on the Iref pin in microampere I think that you don't need this property. Just provide the formula for calculating led-max-microamp value, similarly as you're doing that in the commit message. > + - led-max-microamp: Desired maximum current for each LED in microampere > + (maximum 30000uA) Please add instead of (maximum ...): Valid values: min - max, step by N (rounded {up|down}) E.g. Valid values: 10000 - 30000, step by 1000 (rounded down) > + > +LED sub-node properties: > + - reg : LED channel number (0..2) > + - For other LED properties see: > + Documentation/devicetree/bindings/leds/common.txt > + > +Example: > + > +led1: ncp5623@38 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "onnn,ncp5623"; > + reg = <0x38>; > + > + led1_r@0 { > + label = "ncp:power:red"; > + reg = <0>; > + linux,default-trigger = "default-on"; > + }; > + > + led1_b@1 { > + label = "ncp:power:blue"; > + reg = <1>; > + }; > + > + led1_g@2 { > + label = "ncp:power:green"; > + reg = <2>; > + }; > +}; > -- Best regards, Jacek Anaszewski