From: Alexei Starovoitov <ast@fb.com>
To: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
<linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
<netdev@vger.kernel.org>, Matt Evans <matt@ozlabs.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Denis Kirjanov <kda@linux-powerpc.org>,
"Paul Mackerras" <paulus@samba.org>,
"David S. Miller" <davem@davemloft.net>,
"Ananth N Mavinakayanahalli" <ananth@in.ibm.com>
Subject: Re: [PATCH] ppc: Fix BPF JIT for ABIv2
Date: Tue, 21 Jun 2016 08:45:59 -0700 [thread overview]
Message-ID: <57696137.5020408@fb.com> (raw)
In-Reply-To: <20160621144725.GH3516@indiana.gru.redhat.com>
On 6/21/16 7:47 AM, Thadeu Lima de Souza Cascardo wrote:
>>>
>>> The calling convention is different with ABIv2 and so we'll need changes
>>> in bpf_slow_path_common() and sk_negative_common().
>>
>> How big would those changes be? Do we know?
>>
>> How come no one reported this was broken previously? This is the first I've
>> heard of it being broken.
>>
>
> I just heard of it less than two weeks ago, and only could investigate it last
> week, when I realized mainline was also affected.
>
> It looks like the little-endian support for classic JIT were done before the
> conversion to ABIv2. And as JIT is disabled by default, no one seems to have
> exercised it.
it's not a surprise unfortunately. The JITs that were written before
test_bpf.ko was developed were missing corner cases. Typical tcpdump
would be fine, but fragmented packets, negative offsets and
out-out-bounds wouldn't be handled correctly.
I'd suggest to validate the stable backport with test_bpf as well.
next prev parent reply other threads:[~2016-06-21 15:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 13:32 [PATCH 0/6] eBPF JIT for PPC64 Naveen N. Rao
2016-06-07 13:32 ` [PATCH 1/6] ppc: bpf/jit: Fix/enhance 32-bit Load Immediate implementation Naveen N. Rao
2016-06-07 13:32 ` [PATCH 2/6] ppc: bpf/jit: Optimize 64-bit Immediate loads Naveen N. Rao
2016-06-07 13:32 ` [PATCH 3/6] ppc: bpf/jit: Introduce rotate immediate instructions Naveen N. Rao
2016-06-07 13:32 ` [PATCH 4/6] ppc: bpf/jit: A few cleanups Naveen N. Rao
2016-06-07 13:32 ` [PATCH 5/6] ppc: bpf/jit: Isolate classic BPF JIT specifics into a separate header Naveen N. Rao
2016-06-07 13:32 ` [PATCH 6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF Naveen N. Rao
2016-06-07 22:56 ` Alexei Starovoitov
2016-06-08 17:17 ` Naveen N. Rao
2016-06-09 3:19 ` Nilay Vaish
2016-06-09 6:07 ` Naveen N. Rao
2016-06-17 12:53 ` [6/6] " Michael Ellerman
2016-06-17 13:00 ` [PATCH] ppc: Fix BPF JIT for ABIv2 Thadeu Lima de Souza Cascardo
2016-06-19 17:49 ` Naveen N. Rao
2016-06-20 18:56 ` Thadeu Lima de Souza Cascardo
2016-06-21 8:58 ` Naveen N. Rao
2016-06-21 11:15 ` Michael Ellerman
2016-06-21 14:47 ` Thadeu Lima de Souza Cascardo
2016-06-21 15:45 ` Alexei Starovoitov [this message]
2016-06-22 4:06 ` Michael Ellerman
2016-06-22 7:12 ` Naveen N. Rao
2016-06-22 14:57 ` Naveen N. Rao
2016-06-22 5:20 ` Michael Ellerman
2016-06-22 5:18 ` Michael Ellerman
2016-06-19 17:36 ` [6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF Naveen N. Rao
2016-06-20 23:38 ` Michael Ellerman
2016-06-21 6:58 ` Naveen N. Rao
2016-06-21 11:04 ` Michael Ellerman
2016-06-22 7:06 ` Naveen N. Rao
2016-06-22 10:37 ` [PATCH 6/6] " Michael Ellerman
2016-06-22 12:32 ` Naveen N. Rao
2016-06-11 5:47 ` [PATCH 0/6] eBPF JIT for PPC64 David Miller
2016-06-13 5:40 ` Naveen N. Rao
2016-06-18 4:57 ` mpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57696137.5020408@fb.com \
--to=ast@fb.com \
--cc=ananth@in.ibm.com \
--cc=cascardo@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=kda@linux-powerpc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matt@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox