From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752131AbcFUPyH (ORCPT ); Tue, 21 Jun 2016 11:54:07 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:26611 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbcFUPyD convert rfc822-to-8bit (ORCPT ); Tue, 21 Jun 2016 11:54:03 -0400 Subject: Re: [PATCH] xen/pciback: Fix conf_space read/write overlap check. To: Andrey Grodzovsky , xen-devel@lists.xenproject.org References: <1466519876-7205-1-git-send-email-andrey2805@gmail.com> Cc: jw@quattru.com, Jan Beulich , stable@vger.kernel.org, David Vrabel , Juergen Gross , Linux Kernel Mailing List From: Boris Ostrovsky Message-ID: <576962A2.9080000@oracle.com> Date: Tue, 21 Jun 2016 11:52:02 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1466519876-7205-1-git-send-email-andrey2805@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/21/2016 10:37 AM, Andrey Grodzovsky wrote: > Current overlap check is evaluating to false a case where a filter field > is fully contained (proper subset) of a r/w request. > This change applies classical overlap check instead to include > all the scenarios. > > Related to https://www.mail-archive.com/xen-devel@lists.xen.org/msg72174.html > > Cc: Jan Beulich > Cc: Boris Ostrovsky > Cc: stable@vger.kernel.org > Signed-off-by: Andrey Grodzovsky + David and Juergen (maintainers) and kernel list. Reviewed-by: Boris Ostrovsky > --- > drivers/xen/xen-pciback/conf_space.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/xen/xen-pciback/conf_space.c b/drivers/xen/xen-pciback/conf_space.c > index 8e67336..6a25533 100644 > --- a/drivers/xen/xen-pciback/conf_space.c > +++ b/drivers/xen/xen-pciback/conf_space.c > @@ -183,8 +183,7 @@ int xen_pcibk_config_read(struct pci_dev *dev, int offset, int size, > field_start = OFFSET(cfg_entry); > field_end = OFFSET(cfg_entry) + field->size; > > - if ((req_start >= field_start && req_start < field_end) > - || (req_end > field_start && req_end <= field_end)) { > + if (req_end > field_start && field_end > req_start) { > err = conf_space_read(dev, cfg_entry, field_start, > &tmp_val); > if (err) > @@ -230,8 +229,7 @@ int xen_pcibk_config_write(struct pci_dev *dev, int offset, int size, u32 value) > field_start = OFFSET(cfg_entry); > field_end = OFFSET(cfg_entry) + field->size; > > - if ((req_start >= field_start && req_start < field_end) > - || (req_end > field_start && req_end <= field_end)) { > + if (req_end > field_start && field_end > req_start) { > tmp_val = 0; > > err = xen_pcibk_config_read(dev, field_start,