From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752093AbcFUWBW (ORCPT <rfc822;w@1wt.eu>);
	Tue, 21 Jun 2016 18:01:22 -0400
Received: from mail-lf0-f67.google.com ([209.85.215.67]:34755 "EHLO
	mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751545AbcFUWBV (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 21 Jun 2016 18:01:21 -0400
Subject: Re: [PATCH] scripts/gdb: add constants.py to .gitignore
To: Omar Sandoval <osandov@osandov.com>, Jan Kiszka <jan.kiszka@siemens.com>
References: <a16d95d6c75579653b8a5bee56d753e97fce1d7a.1466452743.git.osandov@fb.com>
Cc: linux-kernel@vger.kernel.org
From: Kieran Bingham <kieran@ksquared.org.uk>
Message-ID: <5769AA04.2020505@bingham.xyz>
Date: Tue, 21 Jun 2016 21:56:36 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <a16d95d6c75579653b8a5bee56d753e97fce1d7a.1466452743.git.osandov@fb.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Omar,

Thanks for spotting, and submitting this.

On 20/06/16 21:00, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
> 
> Since scripts/gdb/linux/constants.py is autogenerated, this should have
> been added to .gitignore when it was introduced.

Absolutely! - This never hit me, as I always build out-of-tree

> Fixes: f197d75fcad1 ("scripts/gdb: provide linux constants")
> Signed-off-by: Omar Sandoval <osandov@fb.com>

Unfortunately - Nacked on the principle of the comment in the top of the
.gitignore file:

  # NOTE! Don't add files that are generated in specific
  # subdirectories here. Add them in the ".gitignore" file
  # in that subdirectory instead.

Could you fix this up (meaning add to the .gitignore under
scripts/gdb/linux) and resend please?

Then I'll add to my queue to send as fixes for current.
 (which I'm hoping to get sent before the weekend, or at the weekend)

> ---
>  .gitignore | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/.gitignore b/.gitignore
> index 0c320bf02586..5cdccb07e3a3 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -112,3 +112,6 @@ all.config
>  
>  # Kdevelop4
>  *.kdev4
> +
> +# Generated for CONFIG_GDB_SCRIPTS
> +/scripts/gdb/linux/constants.py
> 

-- 
Regards

Kieran Bingham