From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751932AbcFUVVV (ORCPT ); Tue, 21 Jun 2016 17:21:21 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:33686 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751209AbcFUVUf (ORCPT ); Tue, 21 Jun 2016 17:20:35 -0400 Subject: Re: [PATCH v2] scripts/gdb: add constants.py to .gitignore To: Omar Sandoval , Jan Kiszka References: <476a1d8754efec5957009db7ae4a9e10451faabb.1466543472.git.osandov@fb.com> Cc: linux-kernel@vger.kernel.org From: Kieran Bingham Message-ID: <5769AF8E.8040807@bingham.xyz> Date: Tue, 21 Jun 2016 22:20:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <476a1d8754efec5957009db7ae4a9e10451faabb.1466543472.git.osandov@fb.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/06/16 22:11, Omar Sandoval wrote: > From: Omar Sandoval > > Since scripts/gdb/linux/constants.py is autogenerated, this should have > been added to .gitignore when it was introduced. > > Fixes: f197d75fcad1 ("scripts/gdb: provide linux constants") > Signed-off-by: Omar Sandoval > --- > Thanks, Kieran, I totally missed the comment in top-level .gitignore. > > scripts/gdb/linux/.gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/gdb/linux/.gitignore b/scripts/gdb/linux/.gitignore > index 52e4e61140d1..d5abd6ce9425 100644 > --- a/scripts/gdb/linux/.gitignore > +++ b/scripts/gdb/linux/.gitignore > @@ -1,2 +1,3 @@ > *.pyc > *.pyo > +/constants.py Does this work with '/' at the beginning of the line? It looks like all the other sub-tree .gitignores don't use a leading / on their ignores If you're happy, I'd like to drop the leading '/'. (I think I can do this silently as I pick the patch if you approve, rather than send another patch for a one-byte change) Other than that: Signed-off-by: Kieran Bingham -- Regards Kieran Bingham