From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752009AbcFUWJJ (ORCPT ); Tue, 21 Jun 2016 18:09:09 -0400 Received: from mail-lf0-f43.google.com ([209.85.215.43]:36419 "EHLO mail-lf0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751454AbcFUWJH (ORCPT ); Tue, 21 Jun 2016 18:09:07 -0400 Subject: Re: [PATCH v2] scripts/gdb: add constants.py to .gitignore To: Omar Sandoval References: <476a1d8754efec5957009db7ae4a9e10451faabb.1466543472.git.osandov@fb.com> <5769AF8E.8040807@bingham.xyz> <20160621213441.GA12969@vader.DHCP.thefacebook.com> Cc: Jan Kiszka , linux-kernel@vger.kernel.org From: Kieran Bingham Message-ID: <5769B9BB.2000806@bingham.xyz> Date: Tue, 21 Jun 2016 23:03:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160621213441.GA12969@vader.DHCP.thefacebook.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/06/16 22:34, Omar Sandoval wrote: > $ git status > On branch master > Untracked files: > (use "git add ..." to include in what will be committed) > > asdf > > nothing added to commit but untracked files present (use "git add" to track) > ---- > > tools/thermal/tmon/.gitignore also uses the leading slash. Aha yes, find -name .gitignore -exec grep -Hin '^/' {} \; ./tools/thermal/tmon/.gitignore:1:/tmon ./.gitignore:44:/tags ./.gitignore:45:/TAGS ./.gitignore:46:/linux ./.gitignore:47:/vmlinux ./.gitignore:48:/vmlinux.32 ./.gitignore:49:/vmlinux-gdb.py ./.gitignore:50:/vmlinuz ./.gitignore:51:/System.map ./.gitignore:52:/Module.markers ./.gitignore:57:/debian/ ./.gitignore:62:/tar-install/ I think we'll call this the exception rather than the norm, and I'd prefer to match the other 177 .gitignore files in their style. > > If you want to drop the /, I'm okay with it. Thanks for the testing, and checking. Patch picked, and '/' silently dropped. -- Regards Kieran Bingham