* Re: [PATCH] xen/pciback: Fix conf_space read/write overlap check. [not found] <1466519876-7205-1-git-send-email-andrey2805@gmail.com> @ 2016-06-21 15:52 ` Boris Ostrovsky 2016-06-22 4:11 ` Juergen Gross 0 siblings, 1 reply; 2+ messages in thread From: Boris Ostrovsky @ 2016-06-21 15:52 UTC (permalink / raw) To: Andrey Grodzovsky, xen-devel Cc: jw, Jan Beulich, stable, David Vrabel, Juergen Gross, Linux Kernel Mailing List On 06/21/2016 10:37 AM, Andrey Grodzovsky wrote: > Current overlap check is evaluating to false a case where a filter field > is fully contained (proper subset) of a r/w request. > This change applies classical overlap check instead to include > all the scenarios. > > Related to https://www.mail-archive.com/xen-devel@lists.xen.org/msg72174.html > > Cc: Jan Beulich <JBeulich@suse.com> > Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> > Cc: stable@vger.kernel.org > Signed-off-by: Andrey Grodzovsky <andrey2805@gmail.com> + David and Juergen (maintainers) and kernel list. Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> > --- > drivers/xen/xen-pciback/conf_space.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/xen/xen-pciback/conf_space.c b/drivers/xen/xen-pciback/conf_space.c > index 8e67336..6a25533 100644 > --- a/drivers/xen/xen-pciback/conf_space.c > +++ b/drivers/xen/xen-pciback/conf_space.c > @@ -183,8 +183,7 @@ int xen_pcibk_config_read(struct pci_dev *dev, int offset, int size, > field_start = OFFSET(cfg_entry); > field_end = OFFSET(cfg_entry) + field->size; > > - if ((req_start >= field_start && req_start < field_end) > - || (req_end > field_start && req_end <= field_end)) { > + if (req_end > field_start && field_end > req_start) { > err = conf_space_read(dev, cfg_entry, field_start, > &tmp_val); > if (err) > @@ -230,8 +229,7 @@ int xen_pcibk_config_write(struct pci_dev *dev, int offset, int size, u32 value) > field_start = OFFSET(cfg_entry); > field_end = OFFSET(cfg_entry) + field->size; > > - if ((req_start >= field_start && req_start < field_end) > - || (req_end > field_start && req_end <= field_end)) { > + if (req_end > field_start && field_end > req_start) { > tmp_val = 0; > > err = xen_pcibk_config_read(dev, field_start, ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] xen/pciback: Fix conf_space read/write overlap check. 2016-06-21 15:52 ` [PATCH] xen/pciback: Fix conf_space read/write overlap check Boris Ostrovsky @ 2016-06-22 4:11 ` Juergen Gross 0 siblings, 0 replies; 2+ messages in thread From: Juergen Gross @ 2016-06-22 4:11 UTC (permalink / raw) To: Boris Ostrovsky, Andrey Grodzovsky, xen-devel Cc: jw, Jan Beulich, stable, David Vrabel, Linux Kernel Mailing List On 21/06/16 17:52, Boris Ostrovsky wrote: > On 06/21/2016 10:37 AM, Andrey Grodzovsky wrote: >> Current overlap check is evaluating to false a case where a filter field >> is fully contained (proper subset) of a r/w request. >> This change applies classical overlap check instead to include >> all the scenarios. >> >> Related to https://www.mail-archive.com/xen-devel@lists.xen.org/msg72174.html >> >> Cc: Jan Beulich <JBeulich@suse.com> >> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> >> Cc: stable@vger.kernel.org >> Signed-off-by: Andrey Grodzovsky <andrey2805@gmail.com> > > + David and Juergen (maintainers) and kernel list. > > Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> Acked-by: Juergen Gross <jgross@suse.com> > > >> --- >> drivers/xen/xen-pciback/conf_space.c | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/xen/xen-pciback/conf_space.c b/drivers/xen/xen-pciback/conf_space.c >> index 8e67336..6a25533 100644 >> --- a/drivers/xen/xen-pciback/conf_space.c >> +++ b/drivers/xen/xen-pciback/conf_space.c >> @@ -183,8 +183,7 @@ int xen_pcibk_config_read(struct pci_dev *dev, int offset, int size, >> field_start = OFFSET(cfg_entry); >> field_end = OFFSET(cfg_entry) + field->size; >> >> - if ((req_start >= field_start && req_start < field_end) >> - || (req_end > field_start && req_end <= field_end)) { >> + if (req_end > field_start && field_end > req_start) { >> err = conf_space_read(dev, cfg_entry, field_start, >> &tmp_val); >> if (err) >> @@ -230,8 +229,7 @@ int xen_pcibk_config_write(struct pci_dev *dev, int offset, int size, u32 value) >> field_start = OFFSET(cfg_entry); >> field_end = OFFSET(cfg_entry) + field->size; >> >> - if ((req_start >= field_start && req_start < field_end) >> - || (req_end > field_start && req_end <= field_end)) { >> + if (req_end > field_start && field_end > req_start) { >> tmp_val = 0; >> >> err = xen_pcibk_config_read(dev, field_start, > > > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-22 4:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1466519876-7205-1-git-send-email-andrey2805@gmail.com>
2016-06-21 15:52 ` [PATCH] xen/pciback: Fix conf_space read/write overlap check Boris Ostrovsky
2016-06-22 4:11 ` Juergen Gross
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox