From: Keerthy <a0393675@ti.com>
To: Suman Anna <s-anna@ti.com>, Keerthy <j-keerthy@ti.com>,
<rnayak@codeaurora.org>, <tony@atomide.com>
Cc: <linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<t-kristo@ti.com>, <afzal@ti.com>, <d-gerlach@ti.com>,
<paul@pwsan.com>, <linux@armlinux.org.uk>
Subject: Re: [PATCH] ARM: AM33xx: PRM: Remove wrongly defined RSTST offset for PER Domain
Date: Wed, 22 Jun 2016 10:54:56 +0530 [thread overview]
Message-ID: <576A2128.8030805@ti.com> (raw)
In-Reply-To: <5769BEF0.4040902@ti.com>
On Wednesday 22 June 2016 03:55 AM, Suman Anna wrote:
> Hi Keerthy,
>
> On 06/21/2016 05:08 AM, Keerthy wrote:
>> As per the TRM: http://www.ti.com/lit/ug/spruh73m/spruh73m.pdf
>> offset 0x4 is reserved for PRM_PER. Hence removing the wrongly
>> defined address offset.
>
> Thanks for the patch. These macros are not used anywhere, so it should
> be safe to remove these. I have tested this patch with an off-tree PRUSS
> driver releasing the reset, it works as expected without throwing any
> issues.
>
> That said, the current omap_hwmod code assumes default rstst_offs and
> st_shift and tries to still write some value into the RSTCTRL register
> in am33xx_prm_deassert_hardreset(), but it didn't have any side-affects
> though on AM33xx. This is what affected the AM437x due to incorrect
> RSTST offset value. That behavior is independent of this patch though.
>
> Tested-by: Suman Anna <s-anna@ti.com>
Thanks for testing!
>
> regards
> Suman
>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>> arch/arm/mach-omap2/prm33xx.h | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/prm33xx.h b/arch/arm/mach-omap2/prm33xx.h
>> index 2bc4ec5..66302c6 100644
>> --- a/arch/arm/mach-omap2/prm33xx.h
>> +++ b/arch/arm/mach-omap2/prm33xx.h
>> @@ -52,8 +52,6 @@
>> /* PRM.PER_PRM register offsets */
>> #define AM33XX_RM_PER_RSTCTRL_OFFSET 0x0000
>> #define AM33XX_RM_PER_RSTCTRL AM33XX_PRM_REGADDR(AM33XX_PRM_PER_MOD, 0x0000)
>> -#define AM33XX_RM_PER_RSTST_OFFSET 0x0004
>> -#define AM33XX_RM_PER_RSTST AM33XX_PRM_REGADDR(AM33XX_PRM_PER_MOD, 0x0004)
>> #define AM33XX_PM_PER_PWRSTST_OFFSET 0x0008
>> #define AM33XX_PM_PER_PWRSTST AM33XX_PRM_REGADDR(AM33XX_PRM_PER_MOD, 0x0008)
>> #define AM33XX_PM_PER_PWRSTCTRL_OFFSET 0x000c
>>
>
next prev parent reply other threads:[~2016-06-22 5:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 10:08 [PATCH] ARM: AM33xx: PRM: Remove wrongly defined RSTST offset for PER Domain Keerthy
2016-06-21 22:25 ` Suman Anna
2016-06-22 5:24 ` Keerthy [this message]
2016-06-22 8:00 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576A2128.8030805@ti.com \
--to=a0393675@ti.com \
--cc=afzal@ti.com \
--cc=d-gerlach@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=paul@pwsan.com \
--cc=rnayak@codeaurora.org \
--cc=s-anna@ti.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox