From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751752AbcFVGBY (ORCPT ); Wed, 22 Jun 2016 02:01:24 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:41020 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751718AbcFVGBU (ORCPT ); Wed, 22 Jun 2016 02:01:20 -0400 Subject: Re: [PATCH v2 0/2] Correct iTCO Watchdog for Apollo Lake To: "Yong, Jonathan" , linux-watchdog@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <1463541972-19758-1-git-send-email-jonathan.yong@intel.com> <1466123817-50679-1-git-send-email-jonathan.yong@intel.com> <576A19BC.4000502@intel.com> Cc: qipeng.zha@intel.com, dvhart@infradead.org, linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: <576A299D.5010300@roeck-us.net> Date: Tue, 21 Jun 2016 23:01:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <576A19BC.4000502@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/21/2016 09:53 PM, Yong, Jonathan wrote: > On 06/17/2016 08:36, Yong, Jonathan wrote: >> These patches fix the iTCO watchdog for Apollo Lake. >> I changed the watchdog memory io to only use 4 bytes rather >> the whole region, I'm not sure if that is the correct way. >> >> The previous 0x30h offset in intel_pmc_ipc.c was for based >> on the earlier BXT-M platform. Apollo Lake has it at 0x40h. >> >> Let me know if the patches need changes. >> Please CC me as I am not subscribed, thanks. >> >> * Resent, typo in linux-kernel email address >> >> Changes since v1: >> * Watchdog NO_REBOOT bit off-by-one corrected. >> >> Yong, Jonathan (2): >> watchdog: iTCO-wdt handle 5th variation for Apollo Lake >> x86: Fix Apollo Lake Watchdog address in PMC driver >> >> drivers/platform/x86/intel_pmc_ipc.c | 10 ++++++---- >> drivers/watchdog/iTCO_wdt.c | 2 ++ >> 2 files changed, 8 insertions(+), 4 deletions(-) >> > > Ping. > > Waiting for an Ack from Darren. Guenter