From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751929AbcFVHMY (ORCPT ); Wed, 22 Jun 2016 03:12:24 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:55299 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750970AbcFVHMW (ORCPT ); Wed, 22 Jun 2016 03:12:22 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68d-f79876d000001436-de-576a3a3950dd Content-transfer-encoding: 8BIT Message-id: <576A3A38.3000306@samsung.com> Date: Wed, 22 Jun 2016 16:11:52 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Lin Huang , heiko@sntech.de, mark.yao@rock-chips.com, myungjoo.ham@samsung.com Cc: mturquette@baylibre.com, sboyd@codeaurora.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, dianders@chromium.org, dbasehore@chromium.org Subject: Re: [RFC PATCH v2 6/6] drm/rockchip: Add dmc notifier in vop driver References: <1465207986-17888-1-git-send-email-hl@rock-chips.com> <1465207986-17888-7-git-send-email-hl@rock-chips.com> In-reply-to: <1465207986-17888-7-git-send-email-hl@rock-chips.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsWyRsSkUNfSKivcYPFmcYvecyeZLF5t3sNm cXbZQTaLK1/fs1n8f/Sa1eLHhlPMFmeb3rBbbHp8jdXiY889VovLu+awWXx68J/ZYseUA0wW F0+5WtxuXMFm8eNMN4sDv8f7G63sHrMbLrJ4XO7rZfLY/u0Bq8f97uNMHpuX1Hv8nbWfxaNv yypGj+3X5jF7fN4kF8AVxWWTkpqTWZZapG+XwJXRsPgmU8EppYq2X/2MDYxbpbsYOTkkBEwk tp/+yQhhi0lcuLeerYuRi0NIYAWjxMzNl5hhio68+M8IkZjFKHGi5zQTSIJXQFDix+R7LF2M HBzMAvISRy5lg4SZBdQlJs1bxAxR/4BR4uzHd8wQ9VoS3b372UFsFgFVielHusDibEDx/S9u sIHMERWIkOg+UQkSFhFIlzjSsp4JYuZOJonPf+VBbGEBH4kPN/9DzT/LKLF08go2kASngJPE gn872EESEgJbOCTufv4GtUxA4tvkQ2CHSgjISmw6APWYpMTBFTdYJjCKzULyziyEd2YheWcB I/MqRtHUguSC4qT0IkO94sTc4tK8dL3k/NxNjMCYP/3vWe8OxtsHrA8xCnAwKvHwMnRlhgux JpYVV+YeYjQFOmIis5Rocj4wseSVxBsamxlZmJqYGhuZW5opifMqSv0MFhJITyxJzU5NLUgt ii8qzUktPsTIxMEp1cAYNr//zmyecLE4JR2FyPkHFU+H93DIXL/2z8d8uqjjsc4y/ilKDySf P5+7uaFyS3JF14vSduX+P+qsSzbO0vtQu/LokQ9/bCMWKh397shUfm3JvZnXd816d+a1S5nD pPgOr7JOE76eNcbSE1U3LX17bBnv32wO1g+vmeRXJMpkzTPzTgj/ud5SiaU4I9FQi7moOBEA x2w1hPQCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHKsWRmVeSWpSXmKPExsVy+t9jQV1Lq6xwg9+7BSx6z51ksni1eQ+b xdllB9ksrnx9z2bx/9FrVosfG04xW5xtesNusenxNVaLjz33WC0u75rDZvHpwX9mix1TDjBZ XDzlanG7cQWbxY8z3SwO/B7vb7Sye8xuuMjicbmvl8lj+7cHrB73u48zeWxeUu/xd9Z+Fo++ LasYPbZfm8fs8XmTXABXVAOjTUZqYkpqkUJqXnJ+SmZeuq2Sd3C8c7ypmYGhrqGlhbmSQl5i bqqtkotPgK5bZg7QG0oKZYk5pUChgMTiYiV9O0wTQkPcdC1gGiN0fUOC4HqMDNBAwhrGjIbF N5kKTilVtP3qZ2xg3CrdxcjJISFgInHkxX9GCFtM4sK99WxdjFwcQgKzGCVO9JxmAknwCghK /Jh8j6WLkYODWUBe4silbJAws4C6xKR5i5gh6h8wSpz9+I4Zol5Lort3PzuIzSKgKjH9SBdY nA0ovv/FDTaQOaICERLdJypBwiIC6RJHWtYzQczcySTx+a88iC0s4CPx4eZ/qPlnGSWWTl7B BpLgFHCSWPBvB/sERqArEc6bhXDeLCTnLWBkXsUokVqQXFCclJ5rmJdarlecmFtcmpeul5yf u4kRnFaeSe1gPLjL/RCjAAejEg9vRE9muBBrYllxZe4hRgkOZiUR3k0mWeFCvCmJlVWpRfnx RaU5qcWHGE2B/pvILCWanA9MeXkl8YbGJmZGlkbmhhZGxuZK4ryP/68LExJITyxJzU5NLUgt gulj4uCUamAUURJcKN4/SevN7UIR7osZoutVd8TdeDD9tNeEX5YzXfnTzMt7IwwX3zDnMv5e MZv9+N4okVudfbvXzzt8hmXx90VuXDtswpWqz4rY1mddsYy537340B3vH2bSzx/PE/3rZSH8 ZYdkQvG6hTcX5bfP5nX9u+uIcOk/jyNXHrcbpa7Q+rp29/pGJZbijERDLeai4kQAQleQ2UED AAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2016년 06월 06일 19:13, Lin Huang wrote: > when in ddr frequency scaling process, vop can not do > enable or disable operate, since dcf will base on vop vblank > time to do frequency scaling and need to get vop irq if there > have vop enabled. So need register to dmc notifier, and we can > get the dmc status. If you want to know when ddr frequency is chanaged, you can use the DEVFREQ_TRANSITION_NOTIFIER notifier[1] (merged to v4.7-rc1) which includes the following notification: - DEVFREQ_PRECHANGE - DEVFREQ_POSTCHANGE [1] "PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER notifier" - https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=0fe3a66410a3ba96679be903f1e287d7a0a264a9 Thanks, Chanwoo Choi > > Signed-off-by: Lin Huang > --- > > Changes in v2: > - None > > Changes in v1: > - use wait_event instead usleep > > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 43 +++++++++++++++++++++++++++-- > 1 file changed, 41 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 1c4d5b5..8286048 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -31,6 +31,8 @@ > #include > #include > > +#include > + > #include "rockchip_drm_drv.h" > #include "rockchip_drm_gem.h" > #include "rockchip_drm_fb.h" > @@ -116,6 +118,10 @@ struct vop { > > const struct vop_data *data; > > + struct notifier_block dmc_nb; > + int dmc_in_process; > + wait_queue_head_t wait_dmc_queue; > + > uint32_t *regsbak; > void __iomem *regs; > > @@ -426,6 +432,21 @@ static void vop_dsp_hold_valid_irq_disable(struct vop *vop) > spin_unlock_irqrestore(&vop->irq_lock, flags); > } > > +static int dmc_notify(struct notifier_block *nb, unsigned long event, > + void *data) > +{ > + struct vop *vop = container_of(nb, struct vop, dmc_nb); > + > + if (event == DMCFREQ_ADJUST) { > + vop->dmc_in_process = 1; > + } else if (event == DMCFREQ_FINISH) { > + vop->dmc_in_process = 0; > + wake_up(&vop->wait_dmc_queue); > + } > + > + return NOTIFY_OK; > +} > + > static void vop_enable(struct drm_crtc *crtc) > { > struct vop *vop = to_vop(crtc); > @@ -434,6 +455,13 @@ static void vop_enable(struct drm_crtc *crtc) > if (vop->is_enabled) > return; > > + /* > + * if in dmc scaling frequency process, wait until it finish > + * use 100ms as timeout time. > + */ > + wait_event_timeout(vop->wait_dmc_queue, > + !vop->dmc_in_process, HZ / 10); > + > ret = pm_runtime_get_sync(vop->dev); > if (ret < 0) { > dev_err(vop->dev, "failed to get pm runtime: %d\n", ret); > @@ -485,6 +513,7 @@ static void vop_enable(struct drm_crtc *crtc) > enable_irq(vop->irq); > > drm_crtc_vblank_on(crtc); > + rockchip_dmc_get(&vop->dmc_nb); > > return; > > @@ -505,6 +534,13 @@ static void vop_crtc_disable(struct drm_crtc *crtc) > return; > > /* > + * if in dmc scaling frequency process, wait until it finish > + * use 100ms as timeout time. > + */ > + wait_event_timeout(vop->wait_dmc_queue, > + !vop->dmc_in_process, HZ / 10); > + > + /* > * We need to make sure that all windows are disabled before we > * disable that crtc. Otherwise we might try to scan from a destroyed > * buffer later. > @@ -517,7 +553,7 @@ static void vop_crtc_disable(struct drm_crtc *crtc) > VOP_WIN_SET(vop, win, enable, 0); > spin_unlock(&vop->reg_lock); > } > - > + rockchip_dmc_put(&vop->dmc_nb); > drm_crtc_vblank_off(crtc); > > /* > @@ -1243,7 +1279,7 @@ static int vop_create_crtc(struct vop *vop) > ret = -ENOENT; > goto err_cleanup_crtc; > } > - > + vop->dmc_nb.notifier_call = dmc_notify; > init_completion(&vop->dsp_hold_completion); > init_completion(&vop->wait_update_complete); > crtc->port = port; > @@ -1465,6 +1501,9 @@ static int vop_bind(struct device *dev, struct device *master, void *data) > /* IRQ is initially disabled; it gets enabled in power_on */ > disable_irq(vop->irq); > > + init_waitqueue_head(&vop->wait_dmc_queue); > + vop->dmc_in_process = 0; > + > ret = vop_create_crtc(vop); > if (ret) > return ret; >