From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751956AbcFVKgv (ORCPT ); Wed, 22 Jun 2016 06:36:51 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:59733 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750854AbcFVKgr (ORCPT ); Wed, 22 Jun 2016 06:36:47 -0400 Subject: Re: [PATCH 1/9] regulator: tps65217: Enable suspend configuration To: Mark Brown References: <1466412218-5906-1-git-send-email-j-keerthy@ti.com> <1466412218-5906-2-git-send-email-j-keerthy@ti.com> <20160621190848.GF28202@sirena.org.uk> <576A64EA.4000607@ti.com> <20160622101611.GI28202@sirena.org.uk> CC: Keerthy , , , , , , , , , From: Keerthy Message-ID: <576A67D9.6080707@ti.com> Date: Wed, 22 Jun 2016 15:56:33 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20160622101611.GI28202@sirena.org.uk> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 22 June 2016 03:46 PM, Mark Brown wrote: > On Wed, Jun 22, 2016 at 03:44:02PM +0530, Keerthy wrote: > >> Hence saving it in a static array and using it later in the ops functions to >> disable or enable regulator during suspend. > > Why a static array and not part of the dynamically allocated driver > data? Okay. That can be done. I can introduce another integer pointer to struct tps65217 which currently holds the driver data. I will allocate memory for TPS65217_NUM_REGULATOR strobes during regulator probe. Is this approach okay? >