From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751773AbcFWGWG (ORCPT <rfc822;w@1wt.eu>);
	Thu, 23 Jun 2016 02:22:06 -0400
Received: from mga04.intel.com ([192.55.52.120]:1568 "EHLO mga04.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751063AbcFWGWE (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 23 Jun 2016 02:22:04 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,515,1459839600"; 
   d="scan'208";a="1007945322"
Subject: Re: [PATCH v4 7/8] mmc: block: register RPMB partition with the RPMB
 subsystem
To: Tomas Winkler <tomas.winkler@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        James Bottomley <James.Bottomley@HansenPartnership.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Vinayak Holikatti <vinholikatti@gmail.com>,
        Andy Lutomirski <luto@kernel.org>,
        =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= <arve@android.com>,
        Michael Ryleev <gmar@google.com>, Joao Pinto <Joao.Pinto@synopsys.com>,
        Christoph Hellwig <hch@lst.de>, Yaniv Gardi <ygardi@codeaurora.org>
References: <1464817292-5407-1-git-send-email-tomas.winkler@intel.com>
 <1464817292-5407-8-git-send-email-tomas.winkler@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
        linux-scsi@vger.kernel.org,
        Alexander Usyskin <alexander.usyskin@intel.com>
From: Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
Message-ID: <576B7F10.2000508@intel.com>
Date: Thu, 23 Jun 2016 09:17:52 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <1464817292-5407-8-git-send-email-tomas.winkler@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 02/06/16 00:41, Tomas Winkler wrote:
> Register eMMC RPMB partition with the RPMB subsystem and provide
> implementation for the RPMB access operations abstracting
> actual multi step process.
> 
> V2: resend
> V3: commit message fix
> V4: Kconfig: use select RPMB to ensure valid configuration
>     Switch back to main area after RPMB access
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> ---

<SNIP>

> +static void mmc_blk_rpmb_add(struct mmc_card *card)
> +{
> +	struct mmc_blk_data *md = dev_get_drvdata(&card->dev);
> +	struct mmc_blk_data *part_md = mmc_blk_rpmb_part_get(md);
> +	struct rpmb_dev *rdev;
> +
> +	if (!part_md)
> +		return;
> +
> +	mmc_blk_rpmb_set_dev_id(&mmc_rpmb_dev_ops, card);
> +
> +	/* RPMB blocks are written in half sectors hence '* 2' */
> +	mmc_rpmb_dev_ops.reliable_wr_cnt = card->ext_csd.rel_sectors * 2;

This looks like it does not support 8KB writes added in v5.1 spec.  Can that
be supported?

> +
> +	rdev = rpmb_dev_register(disk_to_dev(part_md->disk),
> +				  &mmc_rpmb_dev_ops);
> +	if (IS_ERR(rdev)) {
> +		pr_warn("%s: cannot register to rpmb %ld\n",
> +			part_md->disk->disk_name, PTR_ERR(rdev));
> +	}
> +}

<SNIP>