From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751907AbcFWOdu (ORCPT ); Thu, 23 Jun 2016 10:33:50 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36706 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133AbcFWOdr (ORCPT ); Thu, 23 Jun 2016 10:33:47 -0400 Subject: Re: [PATCH v11 2/3] perf config: Reimplement perf_config() introducing new perf_config__init() and perf_config__finish() To: Arnaldo Carvalho de Melo , Taeung Song References: <1466687020-21198-1-git-send-email-treeze.taeung@gmail.com> <1466687020-21198-3-git-send-email-treeze.taeung@gmail.com> <20160623133827.GO4213@kernel.org> <576BEF15.9020405@gmail.com> <20160623143028.GQ4213@kernel.org> Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Ingo Molnar , Peter Zijlstra , Alexander Shishkin , Masami Hiramatsu , Wang Nan , Jiri Olsa , Ingo Molnar From: Taeung Song Message-ID: <576BF345.8070601@gmail.com> Date: Thu, 23 Jun 2016 23:33:41 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160623143028.GQ4213@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/23/2016 11:30 PM, Arnaldo Carvalho de Melo wrote: > Em Thu, Jun 23, 2016 at 11:15:49PM +0900, Taeung Song escreveu: >> >> >> On 06/23/2016 10:38 PM, Arnaldo Carvalho de Melo wrote: >>> Em Thu, Jun 23, 2016 at 10:03:39PM +0900, Taeung Song escreveu: >>>> +/** >>>> + * perf_config_sections__for_each - iterate thru all the sections >>>> + * @list: list_head instance to iterate >>>> + * @section: struct perf_config_section iterator >>>> + */ >>>> +#define perf_config_sections__for_each(list, section) \ >>>> + list_for_each_entry(section, list, node) >>>> + >>> >>> I was almost applying this but then there is a little detail, which is >>> that it is a goal to make the tools/ code look as much as kernel code as >>> possible, to encourage kernel developers to contribute to the tools >>> codebase and also to expose userspace developers to kernel practices. >>> >>> With that said, please rename these for_each macros to for_each_entry, >>> i.e.: >>> >>> perf_config_sections__for_each_entry() >>> perf_config_items__for_each_entry() >>> >>> As for_each and for_each_entry both exist in the kernel and have well >>> know semantics that we want to keep. >>> >>> Probably there are cases in tools/ where we break this rule, I'll check >>> and fix. >>> >> >> Granted ! :) >> >> I sent v12 with above changes a moment ago. > > Thanks, I've just converted evlist__for_each* and strlist__for_each to > this format. > Okey :-D I also think it seems great. Thanks, Taeung