From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752412AbcFWTYJ (ORCPT ); Thu, 23 Jun 2016 15:24:09 -0400 Received: from mxout2.netvision.net.il ([194.90.9.21]:63436 "EHLO mxout2.netvision.net.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752369AbcFWTYG (ORCPT ); Thu, 23 Jun 2016 15:24:06 -0400 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII; format=flowed Message-id: <576C373E.8090407@gmail.com> Date: Thu, 23 Jun 2016 22:23:42 +0300 From: Eli Billauer User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100907 Fedora/3.0.7-1.fc12 Thunderbird/3.0.7 To: Joe Perches Cc: Colin King , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade" References: <1466704091-9360-1-git-send-email-colin.king@canonical.com> <1466708753.1847.17.camel@perches.com> In-reply-to: <1466708753.1847.17.camel@perches.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is getting increasingly embarrassing. I suppose a single patch, fixing both silly mistakes (of mine), would be in place. Colin, would you prefer to submit a patch with both issues fixed yourself, or should I take care of it? Thanks, both of you. Eli On 23/06/16 22:05, Joe Perches wrote: > On Thu, 2016-06-23 at 18:48 +0100, Colin King wrote: > >> trivial fix to spelling mistake in dev_err message >> > [] > >> diff --git a/drivers/char/xillybus/xillybus_core.c b/drivers/char/xillybus/xillybus_core.c >> > [] > >> @@ -658,7 +658,7 @@ static int xilly_obtain_idt(struct xilly_endpoint *endpoint) >> /* Check version number. Accept anything below 0x82 for now. */ >> if (*version> 0x82) { >> > trivia: code doesn't match comment above it. > > >> dev_err(endpoint->dev, >> - "No support for IDT version 0x%02x. Maybe the xillybus driver needs an upgarde. Aborting.\n", >> + "No support for IDT version 0x%02x. Maybe the xillybus driver needs an upgrade. Aborting.\n", >> *version); >> return -ENODEV; >> } >> >