From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751394AbcFWTvY (ORCPT ); Thu, 23 Jun 2016 15:51:24 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:54989 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750729AbcFWTvX (ORCPT ); Thu, 23 Jun 2016 15:51:23 -0400 Subject: Re: [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade" To: Eli Billauer , Joe Perches References: <1466704091-9360-1-git-send-email-colin.king@canonical.com> <1466708753.1847.17.camel@perches.com> <576C373E.8090407@gmail.com> Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org From: Colin Ian King Message-ID: <576C3DAD.60107@canonical.com> Date: Thu, 23 Jun 2016 20:51:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <576C373E.8090407@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/06/16 20:23, Eli Billauer wrote: > This is getting increasingly embarrassing. I suppose a single patch, > fixing both silly mistakes (of mine), would be in place. > > Colin, would you prefer to submit a patch with both issues fixed > yourself, or should I take care of it? Eli, I don't mind if you fix it up. > > Thanks, both of you. > Eli > > On 23/06/16 22:05, Joe Perches wrote: >> On Thu, 2016-06-23 at 18:48 +0100, Colin King wrote: >> >>> trivial fix to spelling mistake in dev_err message >>> >> [] >> >>> diff --git a/drivers/char/xillybus/xillybus_core.c >>> b/drivers/char/xillybus/xillybus_core.c >>> >> [] >> >>> @@ -658,7 +658,7 @@ static int xilly_obtain_idt(struct xilly_endpoint >>> *endpoint) >>> /* Check version number. Accept anything below 0x82 for now. */ >>> if (*version> 0x82) { >>> >> trivia: code doesn't match comment above it. >> >> >>> dev_err(endpoint->dev, >>> - "No support for IDT version 0x%02x. Maybe the xillybus >>> driver needs an upgarde. Aborting.\n", >>> + "No support for IDT version 0x%02x. Maybe the xillybus >>> driver needs an upgrade. Aborting.\n", >>> *version); >>> return -ENODEV; >>> } >>> >> >