From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751286AbcFXAeh (ORCPT ); Thu, 23 Jun 2016 20:34:37 -0400 Received: from regular1.263xmail.com ([211.150.99.136]:55249 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866AbcFXAeg (ORCPT ); Thu, 23 Jun 2016 20:34:36 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: zyw@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: zyw@rock-chips.com X-UNIQUE-TAG: <7d5862df9b59fe063b68a2f170ed763e> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [v3 PATCH 3/5] phy: Add USB Type-C PHY driver for rk3399 To: Guenter Roeck References: <1466686264-6744-1-git-send-email-zyw@rock-chips.com> <1466686264-6744-4-git-send-email-zyw@rock-chips.com> Cc: Douglas Anderson , Tomasz Figa , =?UTF-8?Q?Heiko_St=c3=bcbner?= , =?UTF-8?B?5aea5pm65oOF?= , Guenter Roeck , myungjoo.ham@samsung.com, cw00.choi@samsung.com, "open list:ARM/Rockchip SoC..." , Kever Yang , Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Chris Zhong Message-ID: <576C800D.2050006@rock-chips.com> Date: Fri, 24 Jun 2016 08:34:21 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guenter On 06/24/2016 05:47 AM, Guenter Roeck wrote: > Hi Chris, > > On Thu, Jun 23, 2016 at 5:51 AM, Chris Zhong wrote: >> Add a PHY provider driver for the rk3399 SoC Type-c PHY. The USB >> Type-C PHY is designed to support the USB3 and DP applications. The >> PHY basically has two main components: USB3 and DisplyPort. USB3 >> operates in SuperSpeed mode and the DP can operate at RBR, HBR and >> HBR2 data rates. >> >> Signed-off-by: Chris Zhong >> Signed-off-by: Kever Yang >> > [ ... ] > >> + >> +static void tcphy_get_state(struct rockchip_typec_phy *tcphy, >> + struct extcon_dev *edev) >> +{ >> + int mode; >> + bool plugged, flip, pin_assign, dfp, ufp, dp; >> + >> + ufp = extcon_get_cable_state_(edev, EXTCON_USB); >> + dfp = extcon_get_cable_state_(edev, EXTCON_USB_HOST); >> + dp = extcon_get_cable_state_(edev, EXTCON_DISP_DP); >> + flip = extcon_get_cable_state_(edev, EXTCON_TYPEC_POLARITY); >> + pin_assign = extcon_get_cable_state_(edev, EXTCON_TYPEC_PIN_ASSIGN); >> + >> + plugged = ufp | dfp | dp; >> + tcphy->flip = flip; >> + >> + if (plugged) { >> + if (ufp) { >> + mode = MODE_UFP_USB; >> + } else if (dfp && !dp) { >> + mode = MODE_DFP_USB; >> + } else if (dfp && dp) { >> + mode = MODE_DFP_USB | MODE_DFP_DP; >> + tcphy->pin_assign = pin_assign ? PIN_MAP_D : PIN_MAP_B; >> + } else { >> + mode = MODE_DFP_DP; >> + tcphy->pin_assign = pin_assign ? PIN_MAP_C : PIN_MAP_A; > I am having trouble extracting pin_assign from our code. What > determines if map A or C should be selected ? > > Thanks, > Guenter Oh, forgot rename the macro: PIN_MAP_ should be PIN_ASSIGN_ IF EXTCON_TYPEC_PIN_ASSIGN is attached, Type-C get Pin_Assignment_C(for DP only mode) or Pin_Assignment_D(for DP alt mode), if detached, it get the default Assignment: A(for DP only mode) or B(for DP alt mode),. I am going to add a comment for describe which PIN_ASSIGN_ should be selected in next version, if no one disagrees the usage of cable > >