From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750971AbcFXEGe (ORCPT ); Fri, 24 Jun 2016 00:06:34 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:38876 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750739AbcFXEGd (ORCPT ); Fri, 24 Jun 2016 00:06:33 -0400 Subject: Re: [PATCH V3] clocksource/drivers/arc: Convert init function to return error To: Daniel Lezcano , References: <5763BC00.1030101@synopsys.com> <1466158167-23126-1-git-send-email-daniel.lezcano@linaro.org> CC: , Newsgroups: gmane.linux.kernel,gmane.linux.kernel.arc From: Vineet Gupta Message-ID: <576CB1B6.9090003@synopsys.com> Date: Fri, 24 Jun 2016 09:36:14 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1466158167-23126-1-git-send-email-daniel.lezcano@linaro.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.12.197.158] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 17 June 2016 03:39 PM, Daniel Lezcano wrote: > The init functions do not return any error. They behave as the following: > > - panic, thus leading to a kernel crash while another timer may work and > make the system boot up correctly > > or > > - print an error and let the caller unaware if the state of the system > > Change that by converting the init functions to return an error conforming > to the CLOCKSOURCE_OF_RET prototype. > > Proper error handling (rollback, errno value) will be changed later case > by case, thus this change just return back an error or success in the init > function. > > Signed-off-by: Daniel Lezcano > --- > arch/arc/kernel/time.c | 69 ++++++++++++++++++++++++++++++-------------------- [...] > evt->cpumask = cpumask_of(smp_processor_id()); > @@ -347,24 +355,31 @@ static void __init arc_clockevent_setup(struct device_node *node) > /* Needs apriori irq_set_percpu_devid() done in intc map function */ > ret = request_percpu_irq(arc_timer_irq, timer_irq_handler, > "Timer0 (per-cpu-tick)", evt); > - if (ret) > - panic("clockevent: unable to request irq\n"); > + if (ret) { > + pr_err("clockevent: unable to request irq\n"); > + returnr ret; oops I missed the typo here ! Daniel can u squash this to ur patch ! -Vineet