From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751001AbcFXGlW (ORCPT ); Fri, 24 Jun 2016 02:41:22 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:36766 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750809AbcFXGlU (ORCPT ); Fri, 24 Jun 2016 02:41:20 -0400 Subject: Re: [PATCH V3] clocksource/drivers/arc: Convert init function to return error To: Vineet Gupta , tglx@linutronix.de References: <5763BC00.1030101@synopsys.com> <1466158167-23126-1-git-send-email-daniel.lezcano@linaro.org> <576CB1B6.9090003@synopsys.com> Cc: linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org From: Daniel Lezcano Message-ID: <576CD60D.1020103@linaro.org> Date: Fri, 24 Jun 2016 08:41:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <576CB1B6.9090003@synopsys.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/24/2016 06:06 AM, Vineet Gupta wrote: > On Friday 17 June 2016 03:39 PM, Daniel Lezcano wrote: >> The init functions do not return any error. They behave as the following: >> >> - panic, thus leading to a kernel crash while another timer may work and >> make the system boot up correctly >> >> or >> >> - print an error and let the caller unaware if the state of the system >> >> Change that by converting the init functions to return an error conforming >> to the CLOCKSOURCE_OF_RET prototype. >> >> Proper error handling (rollback, errno value) will be changed later case >> by case, thus this change just return back an error or success in the init >> function. >> >> Signed-off-by: Daniel Lezcano >> --- >> arch/arc/kernel/time.c | 69 ++++++++++++++++++++++++++++++-------------------- > > [...] > >> evt->cpumask = cpumask_of(smp_processor_id()); >> @@ -347,24 +355,31 @@ static void __init arc_clockevent_setup(struct device_node *node) >> /* Needs apriori irq_set_percpu_devid() done in intc map function */ >> ret = request_percpu_irq(arc_timer_irq, timer_irq_handler, >> "Timer0 (per-cpu-tick)", evt); >> - if (ret) >> - panic("clockevent: unable to request irq\n"); >> + if (ret) { >> + pr_err("clockevent: unable to request irq\n"); >> + returnr ret; > > oops I missed the typo here ! > Daniel can u squash this to ur patch ! Yes, no problem. Do you agree to move the driver to drivers/clocksource, so we can add the COMPILE_TEST option ? Thanks. -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog