From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751082AbcFXGuW (ORCPT ); Fri, 24 Jun 2016 02:50:22 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:56945 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750954AbcFXGuR (ORCPT ); Fri, 24 Jun 2016 02:50:17 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8; format=flowed X-AuditID: cbfec7f4-f796c6d000001486-e9-576cd8257eff Content-transfer-encoding: 8BIT Message-id: <576CD823.1080906@samsung.com> Date: Fri, 24 Jun 2016 08:50:11 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 To: Stephan Linz Cc: linux-leds@vger.kernel.org, linux-ide@vger.kernel.org, Joseph Jezak , =?UTF-8?B?SsO2cmcgU29tbWVy?= , Mark Rutland , Richard Purdie , Rob Herring , Jonathan Corbet , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v5] leds: documentation: 'ide-disk' to 'disk-activity' References: <576B8467.3060407@samsung.com> <20160623193857.14538-1-linz@li-pro.net> In-reply-to: <20160623193857.14538-1-linz@li-pro.net> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpkkeLIzCtJLcpLzFFi42I5/e/4VV3VGznhBstei1o8OdDOaDH/yDlW i/PL2lktzj3oYbZY2LaExeLYjkdMFpd3zWGz2PpmHaPF1deLWCyWXr/IZNG69wi7xe5dT1kd eDyWNG9m8lgzbw2jx+Xvb5g9Nq3qZPPY/TbVY3HfZFaPPfN/sHp83iQXwBHFZZOSmpNZllqk b5fAldF3/i5bwWzVihdLZzI1MF6X7WLk5JAQMJG4vuwEO4QtJnHh3no2EFtIYCmjxPeWQBCb V0BQ4sfkeyxdjBwczALyEkcuZYOEmQXMJB61rGPuYuQCKn/GKLHk4htWiHotidmfJ4DNZBFQ ldi5ayULiM0mYCjx88VrJhBbVCBC4s/pfWD1IgJKEpOetLKDDGIW+MMksf3TVbAjhAW8JHbP esECcVCoxNHTU8DinAKmErM/PWKdwCgwC8l9sxDum4XkvgWMzKsYRVNLkwuKk9JzDfWKE3OL S/PS9ZLzczcxQiLmyw7GxcesDjEKcDAq8fC+EM8JF2JNLCuuzD3EKMHBrCTCe/8KUIg3JbGy KrUoP76oNCe1+BCjNAeLkjjv3F3vQ4QE0hNLUrNTUwtSi2CyTBycUg2MIdZh7KvPdutxdqWJ 7maODPWes3M/d6nzj1RB7gWsMd9OyLEfbeD5yct+uDRzWSijy5X+423S5xMXBFp26Z19f2fZ GX4fF2U3QxeuCru4mWfnJGnNLWr71Jrxgv22wFwhvsasQ1+vaPPOvyiSvPnwV/7IW+9F7t9o aO69k9Nzd6pzJKv65e1KLMUZiYZazEXFiQA/NKe0lAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephan, On 06/23/2016 09:38 PM, Stephan Linz wrote: > Cc: Joseph Jezak > Cc: Jörg Sommer > Cc: Mark Rutland > Signed-off-by: Stephan Linz > Acked-by: Rob Herring > Signed-off-by: Jacek Anaszewski > --- > Changes in v5: > - Keep documentation for the old 'ide-disk' device tree > binding, but mark as deprecated and refer to the new > trigger 'disk-activity'. > > Changes in v4: > - Keep the 'ide-disk' trigger and add a second one > for 'disk-activity'. > > Changes in v3: > - Port to kernel 4.x > - Split into platform independent and dependent parts. > > v2: https://patchwork.ozlabs.org/patch/117485/ > v1: http://dev.gentoo.org/~josejx/ata.patch > --- > Documentation/devicetree/bindings/leds/common.txt | 5 ++++- > Documentation/devicetree/bindings/leds/leds-gpio.txt | 4 ++-- > Documentation/laptops/asus-laptop.txt | 2 +- > Documentation/leds/leds-class.txt | 2 +- > 4 files changed, 8 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt > index af10678..1c32e31 100644 > --- a/Documentation/devicetree/bindings/leds/common.txt > +++ b/Documentation/devicetree/bindings/leds/common.txt > @@ -25,8 +25,11 @@ Optional properties for child nodes: > system > "default-on" - LED will turn on (but for leds-gpio see "default-state" > property in Documentation/devicetree/bindings/gpio/led.txt) > + "disk-activity" - LED indicates disk activity, the old name "ide-disk" is > + still valid for backward compatibility > "heartbeat" - LED "double" flashes at a load average based rate > - "ide-disk" - LED indicates disk activity > + "ide-disk" - LED indicates IDE disk activity (deprecated), do not use for > + new implementation, use the new "disk-activity" name instead I'd like to reorganize this change. I think that the two affected properties should be placed next to each other. I'd also remove the remark about ide-disk at disk-activity, since we're leaving ide-disk, with added reference to disk-activity. How about following: + "disk-activity" - LED indicates disk activity - "ide-disk" - LED indicates disk activity + "ide-disk" - LED indicates IDE disk activity (deprecated), in new implementations use "disk-activity" > "timer" - LED flashes at a fixed, configurable rate > > - led-max-microamp : Maximum LED supply current in microamperes. This property > diff --git a/Documentation/devicetree/bindings/leds/leds-gpio.txt b/Documentation/devicetree/bindings/leds/leds-gpio.txt > index cbbeb18..5b1b43a 100644 > --- a/Documentation/devicetree/bindings/leds/leds-gpio.txt > +++ b/Documentation/devicetree/bindings/leds/leds-gpio.txt > @@ -33,9 +33,9 @@ Examples: > leds { > compatible = "gpio-leds"; > hdd { > - label = "IDE Activity"; > + label = "Disk Activity"; > gpios = <&mcu_pio 0 GPIO_ACTIVE_LOW>; > - linux,default-trigger = "ide-disk"; > + linux,default-trigger = "disk-activity"; > }; > > fault { > diff --git a/Documentation/laptops/asus-laptop.txt b/Documentation/laptops/asus-laptop.txt > index 79a1bc6..5f28587 100644 > --- a/Documentation/laptops/asus-laptop.txt > +++ b/Documentation/laptops/asus-laptop.txt > @@ -72,7 +72,7 @@ LEDs > echo 1 > /sys/class/leds/asus::mail/brightness > will switch the mail LED on. > You can also know if they are on/off by reading their content and use > - kernel triggers like ide-disk or heartbeat. > + kernel triggers like disk-activity or heartbeat. > > Backlight > --------- > diff --git a/Documentation/leds/leds-class.txt b/Documentation/leds/leds-class.txt > index 44f5e6b..f1f7ec9 100644 > --- a/Documentation/leds/leds-class.txt > +++ b/Documentation/leds/leds-class.txt > @@ -11,7 +11,7 @@ brightness support so will just be turned on for non-zero brightness settings. > The class also introduces the optional concept of an LED trigger. A trigger > is a kernel based source of led events. Triggers can either be simple or > complex. A simple trigger isn't configurable and is designed to slot into > -existing subsystems with minimal additional code. Examples are the ide-disk, > +existing subsystems with minimal additional code. Examples are the disk-activity, > nand-disk and sharpsl-charge triggers. With led triggers disabled, the code > optimises away. > > -- Best regards, Jacek Anaszewski