From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751868AbcFXOOu (ORCPT ); Fri, 24 Jun 2016 10:14:50 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:39715 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751831AbcFXOOt (ORCPT ); Fri, 24 Jun 2016 10:14:49 -0400 Subject: Re: [PATCH 1/5] hwmon: (tmp102) Use devm_add_action to register cleanup function To: Guenter Roeck , Jean Delvare References: <1466728108-2512-1-git-send-email-linux@roeck-us.net> CC: , From: Nishanth Menon Message-ID: <576D401D.80700@ti.com> Date: Fri, 24 Jun 2016 09:13:49 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1466728108-2512-1-git-send-email-linux@roeck-us.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/23/2016 07:28 PM, Guenter Roeck wrote: > By registering a cleanup function with devm_add_action(), we can > simplify the error path in the probe function and drop the remove > function entirely. > > Signed-off-by: Guenter Roeck I dont seem to have a cover letter to reply to... but anyways.. Before: http://pastebin.ubuntu.com/17801376/ After all 5 patches: http://pastebin.ubuntu.com/17801824/ Fails on beagleboard-X15 with: [ 36.781509] tmp102 0-0048: No cache defaults, reading back from HW [ 36.795940] tmp102 0-0048: unexpected config register value I have'nt bisected down on the specific patch in the series. Have you had a chance to test the series? -- Regards, Nishanth Menon