From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
David Vrabel <david.vrabel@citrix.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Juergen Gross <JGross@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH v2 2/2] xen-pciback: clean up {bar,rom}_init()
Date: Fri, 24 Jun 2016 16:01:45 +0100 [thread overview]
Message-ID: <576D4B59.9070906@citrix.com> (raw)
In-Reply-To: <5756866F02000078000F269D@prv-mh.provo.novell.com>
On 07/06/16 07:31, Jan Beulich wrote:
> - drop unused function parameter of read_dev_bar()
> - drop rom_init() (now identical to bar_init())
> - fold read_dev_bar() into its now single caller
> - simplify determination of 64-bit memory resource
> - use const and unsigned
Please split this in 5 separate patches for easier review.
Especially as often anyone writing "simplify" means "accidentally break".
David
next prev parent reply other threads:[~2016-06-24 15:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 6:27 [PATCH v2 0/2] xen-pciback: correct and clean up BAR handling Jan Beulich
2016-06-07 6:30 ` [PATCH v2 1/2] xen-pciback: return proper values during BAR sizing Jan Beulich
2016-06-07 14:06 ` Boris Ostrovsky
2016-06-07 14:14 ` Jan Beulich
2016-06-24 9:13 ` [PATCH v3 " Jan Beulich
2016-06-24 14:08 ` [Xen-devel] " David Vrabel
2016-06-07 6:31 ` [PATCH v2 2/2] xen-pciback: clean up {bar,rom}_init() Jan Beulich
2016-06-07 14:06 ` Boris Ostrovsky
2016-06-24 15:01 ` David Vrabel [this message]
2016-06-27 7:24 ` [Xen-devel] " Jan Beulich
2016-06-29 12:42 ` [Xen-devel] [PATCH v2 2/2] xen-pciback: clean up {bar, rom}_init() David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576D4B59.9070906@citrix.com \
--to=david.vrabel@citrix.com \
--cc=JBeulich@suse.com \
--cc=JGross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox