From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751281AbcFXPDP (ORCPT <rfc822;w@1wt.eu>);
	Fri, 24 Jun 2016 11:03:15 -0400
Received: from smtp02.citrix.com ([66.165.176.63]:29189 "EHLO
	SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750988AbcFXPDO (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 24 Jun 2016 11:03:14 -0400
X-IronPort-AV: E=Sophos;i="5.26,521,1459814400"; 
   d="scan'208";a="369472110"
Subject: Re: [Xen-devel] [PATCH v2 2/2] xen-pciback: clean up {bar,rom}_init()
To: Jan Beulich <JBeulich@suse.com>, David Vrabel <david.vrabel@citrix.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Juergen Gross <JGross@suse.com>
References: <5756857802000078000F268D@prv-mh.provo.novell.com>
 <5756866F02000078000F269D@prv-mh.provo.novell.com>
CC: xen-devel <xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>
From: David Vrabel <david.vrabel@citrix.com>
Message-ID: <576D4B59.9070906@citrix.com>
Date: Fri, 24 Jun 2016 16:01:45 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.5.0
MIME-Version: 1.0
In-Reply-To: <5756866F02000078000F269D@prv-mh.provo.novell.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-DLP: MIA2
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/06/16 07:31, Jan Beulich wrote:
> - drop unused function parameter of read_dev_bar()
> - drop rom_init() (now identical to bar_init())
> - fold read_dev_bar() into its now single caller
> - simplify determination of 64-bit memory resource
> - use const and unsigned

Please split this in 5 separate patches for easier review.

Especially as often anyone writing "simplify" means "accidentally break".

David