From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751550AbcFYIeO (ORCPT ); Sat, 25 Jun 2016 04:34:14 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:36877 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751141AbcFYIeM (ORCPT ); Sat, 25 Jun 2016 04:34:12 -0400 Subject: Re: [PATCH v2 2/5] input: pmic8xxx-pwrkey: Add support for pm8018 pwrkey To: Dmitry Torokhov References: <1466759887-25394-1-git-send-email-narmstrong@baylibre.com> <1466759887-25394-3-git-send-email-narmstrong@baylibre.com> <20160624220748.GB11719@dtor-ws> Cc: andy.gross@linaro.org, david.brown@linaro.org, lee.jones@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, rtc-linux@googlegroups.com, Rob Herring From: Neil Armstrong Organization: Baylibre Message-ID: <576E41FC.1080102@baylibre.com> Date: Sat, 25 Jun 2016 10:34:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160624220748.GB11719@dtor-ws> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/25/2016 12:07 AM, Dmitry Torokhov wrote: > On Fri, Jun 24, 2016 at 11:18:04AM +0200, Neil Armstrong wrote: >> In order to support pwrkey for Qualcomm MDM9615 SoC, add support >> for the pm8018 pwrkey in pmic8xxx-pwrkey. >> >> Reviewed-by: Bjorn Andersson >> Signed-off-by: Neil Armstrong > > NAK. Hi Dmitry, Actually, the new compatible string make sense, because the driver is compatible with the "pm8018" pwrkey but from a system point of view, it's not a pm8921 pwrkey, hence the new compatible string. Rob Herring was very clear with me with this policy, and it will simplify further driver architecture change since it will not imply devicetree changes anymore. My point of view is that the devicetree describes the hardware and need to have SoC specific compatible string since it describes the actual silicon, and drivers must make sure to handle all the SoC or family variants using the compatible string and the match data. Neil > >> --- >> Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt | 1 + >> drivers/input/misc/pmic8xxx-pwrkey.c | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt b/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt >> index 588536c..9e530e2 100644 >> --- a/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt >> +++ b/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt >> @@ -8,6 +8,7 @@ PROPERTIES >> Definition: must be one of: >> "qcom,pm8058-pwrkey" >> "qcom,pm8921-pwrkey" >> + "qcom,pm8018-pwrkey" >> >> - reg: >> Usage: required >> diff --git a/drivers/input/misc/pmic8xxx-pwrkey.c b/drivers/input/misc/pmic8xxx-pwrkey.c >> index 67aab86..f6f9b87 100644 >> --- a/drivers/input/misc/pmic8xxx-pwrkey.c >> +++ b/drivers/input/misc/pmic8xxx-pwrkey.c >> @@ -446,6 +446,7 @@ static int pmic8xxx_pwrkey_remove(struct platform_device *pdev) >> } >> >> static const struct of_device_id pm8xxx_pwr_key_id_table[] = { >> + { .compatible = "qcom,pm8018-pwrkey", .data = &pm8921_pwrkey_shutdown }, >> { .compatible = "qcom,pm8058-pwrkey", .data = &pm8058_pwrkey_shutdown }, >> { .compatible = "qcom,pm8921-pwrkey", .data = &pm8921_pwrkey_shutdown }, >> { } >> -- >> 1.9.1 >> >