From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751746AbcF0CzA (ORCPT <rfc822;w@1wt.eu>);
	Sun, 26 Jun 2016 22:55:00 -0400
Received: from mail-qt0-f182.google.com ([209.85.216.182]:32991 "EHLO
	mail-qt0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751629AbcF0Cy7 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 26 Jun 2016 22:54:59 -0400
Subject: Re: [PATCH v13 10/10] kprobes: Add arm64 case in kprobe example
 module
To: Huang Shijie <shijie.huang@arm.com>
References: <1464924384-15269-1-git-send-email-dave.long@linaro.org>
 <1464924384-15269-11-git-send-email-dave.long@linaro.org>
 <20160608054903.GA8198@sha-win-210.asiapac.arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
        James Morse <james.morse@arm.com>, Marc Zyngier <marc.zyngier@arm.com>,
        Pratyush Anand <panand@redhat.com>,
        Sandeepa Prabhu <sandeepa.s.prabhu@gmail.com>,
        Will Deacon <will.deacon@arm.com>, William Cohen <wcohen@redhat.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Steve Capper <steve.capper@linaro.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Li Bin <huawei.libin@huawei.com>,
        Adam Buchbinder <adam.buchbinder@gmail.com>,
        =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Christoffer Dall <christoffer.dall@linaro.org>,
        Daniel Thompson <daniel.thompson@linaro.org>,
        Dave P Martin <Dave.Martin@arm.com>,
        Jens Wiklander <jens.wiklander@linaro.org>,
        Jisheng Zhang <jszhang@marvell.com>,
        John Blackwood <john.blackwood@ccur.com>,
        Mark Rutland <mark.rutland@arm.com>, Petr Mladek <pmladek@suse.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Vladimir Murzin <Vladimir.Murzin@arm.com>,
        Yang Shi <yang.shi@linaro.org>, Zi Shen Lim <zlim.lnx@gmail.com>,
        yalin wang <yalin.wang2010@gmail.com>, Mark Brown <broonie@kernel.org>,
        nd@arm.com
From: David Long <dave.long@linaro.org>
Message-ID: <5770957B.4090104@linaro.org>
Date: Sun, 26 Jun 2016 22:54:51 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20160608054903.GA8198@sha-win-210.asiapac.arm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/08/2016 01:49 AM, Huang Shijie wrote:
> On Thu, Jun 02, 2016 at 11:26:24PM -0400, David Long wrote:
>> From: Sandeepa Prabhu <sandeepa.s.prabhu@gmail.com>
>>
>> Add info prints in sample kprobe handlers for ARM64
>>
>> Signed-off-by: Sandeepa Prabhu <sandeepa.s.prabhu@gmail.com>
>> ---
>>   samples/kprobes/kprobe_example.c | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
>> index ed0ca0c..aad8e6f 100644
>> --- a/samples/kprobes/kprobe_example.c
>> +++ b/samples/kprobes/kprobe_example.c
>> @@ -46,6 +46,10 @@ static int handler_pre(struct kprobe *p, struct pt_regs *regs)
>>   			" ex1 = 0x%lx\n",
>>   		p->symbol_name, p->addr, regs->pc, regs->ex1);
>>   #endif
>> +#ifdef CONFIG_ARM64
>> +	pr_info("pre_handler: p->addr = 0x%p, pc = 0x%lx\n",
>> +		p->addr, (long)regs->pc);
> Please add the "p->symbol_name" for the log, just as the above line.
>

The v14 patch set will have changes that align more closely to how this 
works on other architectures.

>> +#endif
>>
>>   	/* A dump_stack() here will give a stack backtrace */
>>   	return 0;
>> @@ -71,6 +75,10 @@ static void handler_post(struct kprobe *p, struct pt_regs *regs,
>>   	printk(KERN_INFO "<%s> post_handler: p->addr = 0x%p, ex1 = 0x%lx\n",
>>   		p->symbol_name, p->addr, regs->ex1);
>>   #endif
>> +#ifdef CONFIG_ARM64
>> +	pr_info("post_handler: p->addr = 0x%p, pc = 0x%lx\n",
>> +		p->addr, (long)regs->pc);
>> +#endif
>>   }
> Ditto.
>
> thanks
> Huang Shijie
>

Thanks,
-dl