From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751963AbcF0Jq4 (ORCPT ); Mon, 27 Jun 2016 05:46:56 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:5601 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751713AbcF0Jqo (ORCPT ); Mon, 27 Jun 2016 05:46:44 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Mon, 27 Jun 2016 02:45:35 -0700 Message-ID: <5770F2CB.2090109@nvidia.com> Date: Mon, 27 Jun 2016 15:02:59 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Jon Hunter , Wolfram Sang , Stephen Warren , Thierry Reding , Alexandre Courbot CC: Shardar Shariff Md , , , Subject: Re: [PATCH] i2c: tegra: Correct error path in probe References: <1465936007-18599-1-git-send-email-jonathanh@nvidia.com> <5770F1D4.8000406@nvidia.com> In-Reply-To: <5770F1D4.8000406@nvidia.com> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRHKMAIL103.nvidia.com (10.25.59.17) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 27 June 2016 02:58 PM, Jon Hunter wrote: > Hi all, > > On 14/06/16 21:26, Jon Hunter wrote: >> @@ -912,7 +912,7 @@ static int tegra_i2c_probe(struct platform_device *pdev) >> ret = tegra_i2c_init(i2c_dev); >> if (ret) { >> dev_err(&pdev->dev, "Failed to initialize i2c controller"); >> - goto unprepare_div_clk; >> + goto disable_div_clk; >> } >> Yes, this looks correct. Acked-by: Laxman Dewangan