From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752021AbcF0Ld6 (ORCPT ); Mon, 27 Jun 2016 07:33:58 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:25521 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751806AbcF0Ld4 (ORCPT ); Mon, 27 Jun 2016 07:33:56 -0400 X-AuditID: cbfec7f4-f796c6d000001486-06-57710f20cd3e Subject: Re: [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node' To: Arnd Bergmann , Rob Herring References: <20160627110303.3391769-1-arnd@arndb.de> Cc: Kefeng Wang , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-id: <57710F1F.8090304@samsung.com> Date: Mon, 27 Jun 2016 13:33:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <20160627110303.3391769-1-arnd@arndb.de> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRmVeSWpSXmKPExsVy+t/xa7qK/IXhBrfVLf5OOsZu8fqFoUX/ 49fMFpseX2O1uLxrDpvFjPP7mCz+79nBbtH4+T6jA4fH71+TGD1ajrxl9di0qpPNY/OSeo++ LasYPT5vkgtgi+KySUnNySxLLdK3S+DKWD5hKWPBDbaKS3+3szUwnmTtYuTkkBAwkbjV94YR whaTuHBvPVsXIxeHkMBSRol9HxtYIJxnjBL7F39gA6kSFvCWaOu7zgRiiwg4SKy63goWFwKa tPfxS7BuZoFtjBLbzs5kAUmwCRhLbF6+BKyIV0BL4s/rc+wgNouAqsTjzlYwW1QgQmLW9h9M EDWCEj8m3wPr5RQwlXj4ejtQDQfQUD2J+xe1QMLMAvISm9e8ZZ7AKDALSccshKpZSKoWMDKv YhRNLU0uKE5KzzXUK07MLS7NS9dLzs/dxAgJ+S87GBcfszrEKMDBqMTDe0GmIFyINbGsuDL3 EKMEB7OSCG8GX2G4EG9KYmVValF+fFFpTmrxIUZpDhYlcd65u96HCAmkJ5akZqemFqQWwWSZ ODilGhhzp2hc2Vbi3cJ0x3SZ+nEu6WrGSRtr985/uP3lRY/M+bdDeoL/ae5//q5opfyzx6p8 9fZCGe759WzHmHjrRLInFjhNKNsenG1h1SDgHXekf6/DdM/9uec8EzyTNq27ueFKyWm3rW8D jTMX9kx5l52RskL20DZjNSnmqe1qCwpUZshPiHJxXK3EUpyRaKjFXFScCAAQ3hk5dQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/27/2016 01:02 PM, Arnd Bergmann wrote: > The change to simplify of_platform_populate() had an unintended > side-effect of introducing a build warning on s3c64xx: > > In file included from arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c:18:0: > arch/arm/mach-s3c64xx/common.h:27:30: error: 'struct device_node' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > > This adds a forward-declaration for the structure name in the > header to avoid the warning. > > Signed-off-by: Arnd Bergmann > Fixes: 850bea2335e4 ("arm: Remove unnecessary of_platform_populate with default match table") > --- > Rob, can you apply this on top of the devicetree git so we don't > have to coordinate the merges? Acked-by: Krzysztof Kozlowski BR, Krzysztof