From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753046AbcIBVhn (ORCPT <rfc822;w@1wt.eu>);
        Fri, 2 Sep 2016 17:37:43 -0400
Received: from mout.kundenserver.de ([217.72.192.75]:58533 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752827AbcIBVhm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 2 Sep 2016 17:37:42 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: linaro-mm-sig@lists.linaro.org
Cc: Laura Abbott <labbott@redhat.com>, kbuild test robot <lkp@intel.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>, devel@driverdev.osuosl.org,
        Jon Medhurst <tixy@linaro.org>,
        Android Kernel Team <kernel-team@android.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jeremy Gebben <jgebben@codeaurora.org>,
        Liviu Dudau <Liviu.Dudau@arm.com>,
        Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= <arve@android.com>,
        linux-kernel@vger.kernel.org, Riley Andrews <riandrews@android.com>,
        John Stultz <john.stultz@linaro.org>, kbuild-all@01.org,
        Eun Taik Lee <eun.taik.lee@samsung.com>,
        Chen Feng <puck.chen@hisilicon.com>,
        Brian Starkey <brian.starkey@arm.com>
Subject: Re: [Linaro-mm-sig] [PATCHv2 4/4] staging: android: ion: Add ioctl to query available heaps
Date: Fri, 02 Sep 2016 23:37:19 +0200
Message-ID: <5771220.ipmQs8UScq@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <f992a74b-7074-5e62-9f09-652ee4619fad@redhat.com>
References: <201609020726.BYQpL5LC%fengguang.wu@intel.com> <f992a74b-7074-5e62-9f09-652ee4619fad@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:YvezSrdMcszIJjgIx32+E//sbL4xOxYMhGdCmVrEgLCfIH3pbXH
 OKvrwKQ35ezxYPpjswpEceM0HY0z/GKd0hACLBbkN0jgHejO1hR696/GcvNxGYp3eYzXoF0
 c/UA01a1KnSAgfD/sGQvyhzUQzsK8dYlvbKLWl/Gm/GZ0yiZYqrESErVk6cUpDDKhCFa3qS
 1C9LAkhgEJv5sDvGFvxvA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:7BqkXXZoFWs=:LUrSw5ZQGMQwvkeh7aiOe6
 Dz+EPlgC1tu8/e6sFrcFyQ2QLCM6vSVRLlvaL0YlYCEnqoJhVZf6aYLDP/EOrSlbIIwcz6zxj
 6YAwkuHO2JmNEgtqDjvIjwZRceREqq6W1N7mRoyyKK6hFb1vjqvDJQp0qeu+j3olxjfWEv/XP
 xEW/yVAbgqK3MSXltKPIqgHjwLM0cz7C1XRynfX/TjKhcw1ZAOmKCHSp6bsmif2yInLfNZJVc
 S8y8WtIcrnIFGBjPVUG/ulPIUTJ00I58/MlQecbJF9OwRGetGA7ttNENMkgPan/jXzkFBldIq
 x2GGyHgh9cwivws2AST6H8QrWS9r8K0dKghVd5UxQF2FsU4z7KV6WEusQ3C4bpj7xohrmGUwB
 f1iqPWSR+G/q3V0l9Qbl1GsEeQhHYodu5u6aon59mCfXCNm6pQ1I3n8wvd1wE63OYZlun7M/B
 iEzOD0dSAPWo8+UNLiGDlpGvZFPj/0oFRK2UFKo1x4Tw89eoSepA7Dc4NQpgPv5eW2XJuZ/iE
 RZu6JXTQIF/Szx33hdxLNtD74H7/hmE7i+eACU91d4CWcxWBMHuOHZOzOtfDVhmKDORY6Cgaq
 dn3mNKvv6AlFclWQVdqgmE1pTOj0B751eDI/jo5PNlXgZUjI+DNFHvnOm3htVvmCvGw54OqAA
 YXZY5O5ZMHbDEnb+py51Pfwi0wIwMWJ+JaSZMSGLdoMbShLTaF5liqovnruqn8bPa+GfcEt0p
 rO7nJsnljrHO+bl1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday, September 2, 2016 2:27:21 PM CEST Laura Abbott wrote:
> >
> > All warnings (new ones prefixed by >>):
> >
> >    drivers/staging/android/ion/ion.c: In function 'ion_query_heaps':
> >>> drivers/staging/android/ion/ion.c:1181:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> >       (struct ion_heap_data __user *)query->heaps;
> >       ^
> >
> 
> botching-up-ioctls.txt says:
> 
>   * Pointers are __u64, cast from/to a uintprt_t on the userspace side and
>     from/to a void __user * in the kernel. Try really hard not to delay this
>     conversion or worse, fiddle the raw __u64 through your code since that
>     diminishes the checking tools like sparse can provide.
> 
> This doesn't seem like it will work on 32-bit systems since you'll end up
> with the warning above. Is there a better option or did I misunderstand
> how that is supposed to work?
> 

I don't know a better way that two cast, doing
	
	(struct ion_heap_data __user *)(uintptr_t)query->heaps;

It may help to put this into an inline function though.

	Arnd