From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751949AbcF0SPb (ORCPT ); Mon, 27 Jun 2016 14:15:31 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:50104 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751601AbcF0SP3 (ORCPT ); Mon, 27 Jun 2016 14:15:29 -0400 Subject: Re: linux-next: Tree for Jun 27 (pinctrl && !CONFIG_OF) To: Stephen Rothwell , linux-next@vger.kernel.org References: <20160627163939.20e454d5@canb.auug.org.au> Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, "devicetree@vger.kernel.org" , Arnd Bergmann , Linus Torvalds From: Randy Dunlap Message-ID: <57716D3D.4070302@infradead.org> Date: Mon, 27 Jun 2016 11:15:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <20160627163939.20e454d5@canb.auug.org.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/26/16 23:39, Stephen Rothwell wrote: > Hi all, > > Changes since 20160624: > on i386, when CONFIG_OF is not enabled ... but OF_GPIO is enabled due to this in drivers/gpio/Kconfig: config OF_GPIO def_bool y depends on OF || COMPILE_TEST (above from commit 1e4a80640338924b9f9fd7a121ac31d08134410a from Alexander Stein ) ../drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:381:20: error: 'pinconf_generic_dt_node_to_map_pin' undeclared here (not in a function) ../drivers/pinctrl/bcm/pinctrl-cygnus-mux.c:739:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function) ../drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:365:20: error: 'pinconf_generic_dt_node_to_map_pin' undeclared here (not in a function) because that function is only present when CONFIG_OF is enabled. Also, why does that commit (1e4a80640338924b9f9fd7a121ac31d08134410a) not have any other S-O-B lines in it? like whoever merged it? -- ~Randy