From: Michal Marek <mmarek@suse.com>
To: Thorsten Leemhuis <regressions@leemhuis.info>,
"Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
Cc: "linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>,
"mmarek@suse.cz" <mmarek@suse.cz>,
"nicolas.pitre@linaro.org" <nicolas.pitre@linaro.org>
Subject: Re: Regression in "kbuild: fix if_change and friends to consider argument order"
Date: Mon, 27 Jun 2016 22:10:11 +0200 [thread overview]
Message-ID: <57718823.9030009@suse.com> (raw)
In-Reply-To: <2d0fa5b3-eb47-60af-9c92-49c31ae0fe86@leemhuis.info>
Dne 26.6.2016 v 12:43 Thorsten Leemhuis napsal(a):
> On 09.06.2016 01:29, Zanoni, Paulo R wrote:
>> Em Ter, 2016-06-07 às 23:52 +0200, Michal Marek escreveu:
>>> On Tue, Jun 07, 2016 at 02:10:28PM +0000, Zanoni, Paulo R wrote:
>>> From b36fad65d61fffe4b662d4bfb1ed673c455a36a2 Mon Sep 17 00:00:00
>>> 2001
>>> From: Michal Marek <mmarek@suse.com>
>>> Date: Tue, 7 Jun 2016 11:57:02 +0200
>>> Subject: [PATCH] kbuild: Initialize exported variables
>>>
>>> The NOSTDINC_FLAGS variable is exported, so it needs to be cleared to
>>> avoid duplicating its content when running make from within make
>>> (e.g.
>>> in the packaging targets). This became an issue after commit
>>> 9c8fa9bc08f6 ("kbuild: fix if_change and friends to consider argument
>>> order"), which no longer ignores the duplicate options. As Paulo
>>> Zanoni
>>> points out, the LDFLAGS_vmlinux variable has the same problem.
>>>
>>> Reported-by: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
>>> Fixes: 9c8fa9bc08f6 ("kbuild: fix if_change and friends to consider
>>> argument order")
>>> Signed-off-by: Michal Marek <mmarek@suse.com>
>> Works for me.
>> Tested-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Michal, what's the status here? This made it on my 4.7 regressions
> report due to the "regression" keyword in the subject.
I forgot to send it to Linus, fixed now. Thanks for the reminder.
Michal
prev parent reply other threads:[~2016-06-27 20:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 1:38 Regression in "kbuild: fix if_change and friends to consider argument order" Zanoni, Paulo R
2016-06-07 9:38 ` Michal Marek
2016-06-07 9:58 ` Michal Marek
2016-06-07 10:03 ` Masahiro Yamada
2016-06-07 10:48 ` Michal Marek
2016-06-07 11:29 ` Masahiro Yamada
2016-06-07 14:10 ` Zanoni, Paulo R
2016-06-07 21:52 ` Michal Marek
2016-06-08 23:29 ` Zanoni, Paulo R
2016-06-26 10:43 ` Thorsten Leemhuis
2016-06-27 20:10 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57718823.9030009@suse.com \
--to=mmarek@suse.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=nicolas.pitre@linaro.org \
--cc=paulo.r.zanoni@intel.com \
--cc=regressions@leemhuis.info \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).