From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751949AbcF1Ekf (ORCPT <rfc822;w@1wt.eu>);
	Tue, 28 Jun 2016 00:40:35 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:61877 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750848AbcF1Eke (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 28 Jun 2016 00:40:34 -0400
From: Tan Xiaojun <tanxiaojun@huawei.com>
Subject: =?UTF-8?Q?IP_ID_check_=28flush=5fid=29_in_inet=5fgro=5freceive_is_n?=
 =?UTF-8?Q?ecessary_or_not=ef=bc=9f?=
To: <davem@davemloft.net>, <kuznet@ms2.inr.ac.ru>, <jmorris@namei.org>,
        <yoshfuji@linux-ipv6.org>, <kaber@trash.net>, <aduyck@mirantis.com>,
        <hkchu@google.com>
CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Message-ID: <5771FFA1.3050306@huawei.com>
Date: Tue, 28 Jun 2016 12:40:01 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.21.79]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020204.5771FFAC.01D1,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: ce11dc5aafd08efb67c05b1331774dfe
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi everyone,

	I'm sorry to bother you. But I was confused.

	The IP ID check (flush_id) in inet_gro_receive is only used by tcp_gro_receive, and in tcp_gro_receive we have tcphdr check to ensure the order of skbs,
	like below:

	flush |= (__force int)(th->ack_seq ^ th2->ack_seq);
	flush |= (ntohl(th2->seq) + skb_gro_len(p)) ^ ntohl(th->seq);

	So if I remove the IP ID check in inet_gro_receive, there will be a problem ? And under what circumstances ?


Thanks.
Xiaojun.