From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752060AbcF1Ho2 (ORCPT ); Tue, 28 Jun 2016 03:44:28 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:52843 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750753AbcF1HoZ (ORCPT ); Tue, 28 Jun 2016 03:44:25 -0400 Subject: Re: [PATCH v3 03/10] input: tps65218-pwrbutton: Add platform_device_id table To: Lee Jones References: <1467093980-11458-1-git-send-email-j-keerthy@ti.com> <1467093980-11458-4-git-send-email-j-keerthy@ti.com> <20160628064948.GB6720@dell> <57721F71.5010700@ti.com> <20160628074110.GH6720@dell> CC: Keerthy , , , , , , , , , , , , From: Keerthy Message-ID: <57722AB8.8020208@ti.com> Date: Tue, 28 Jun 2016 13:13:52 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20160628074110.GH6720@dell> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 28 June 2016 01:11 PM, Lee Jones wrote: > On Tue, 28 Jun 2016, Keerthy wrote: > >> >> >> On Tuesday 28 June 2016 12:19 PM, Lee Jones wrote: >>> On Tue, 28 Jun 2016, Keerthy wrote: >>> >>>> platform_device_id table is needed for adding the tps65218-pwrbutton >>>> module to the mfd_cell array. >>>> >>>> Signed-off-by: Keerthy >>>> --- >>>> drivers/input/misc/tps65218-pwrbutton.c | 7 +++++++ >>>> 1 file changed, 7 insertions(+) >>>> >>>> diff --git a/drivers/input/misc/tps65218-pwrbutton.c b/drivers/input/misc/tps65218-pwrbutton.c >>>> index 2bba8de..a0cb7d2 100644 >>>> --- a/drivers/input/misc/tps65218-pwrbutton.c >>>> +++ b/drivers/input/misc/tps65218-pwrbutton.c >>>> @@ -113,12 +113,19 @@ static const struct of_device_id of_tps65218_pwr_match[] = { >>>> }; >>>> MODULE_DEVICE_TABLE(of, of_tps65218_pwr_match); >>>> >>>> +static const struct platform_device_id tps65218_pwrbtn_id_table[] = { >>>> + { "tps65218-pwrbutton", }, >>>> + { /* sentinel */ } >>>> +} >>> >>> Missing ';'. Did you build test this? >> >> Oops sorry for the mess. Yes i built and booted. While reviewing and just >> before sending i have accidentally deleted. I will send a v4 in a bit. I >> will send v4 of this patch. >> >> I just checked now. It somehow compiles silently even with the ';' missing! >> I will send a v4. > > Are you sure this driver is enable in the CONFIG? Yes! I think the MACRO Below covers up for the missing ';' and hence went unnoticed :-/ > >>>> +MODULE_DEVICE_TABLE(platform, tps65218_pwrbtn_id_table); >>>> + >>>> static struct platform_driver tps65218_pwron_driver = { >>>> .probe = tps65218_pwron_probe, >>>> .driver = { >>>> .name = "tps65218_pwrbutton", >>>> .of_match_table = of_tps65218_pwr_match, >>>> }, >>>> + .id_table = tps65218_pwrbtn_id_table, >>>> }; >>>> module_platform_driver(tps65218_pwron_driver); >>>> >>> >