From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751489AbcF2GRJ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 29 Jun 2016 02:17:09 -0400
Received: from comal.ext.ti.com ([198.47.26.152]:52066 "EHLO comal.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750756AbcF2GRF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 29 Jun 2016 02:17:05 -0400
Subject: Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection
 hardware
To: Stephen Boyd <stephen.boyd@linaro.org>,
        Chanwoo Choi <cw00.choi@samsung.com>
References: <20160626055647.18898-1-stephen.boyd@linaro.org>
 <5770D847.7060901@ti.com>
 <146705583219.30684.18055040268826215722@sboyd-linaro>
 <57721AEA.6010509@ti.com>
 <146710362771.3879.13924434427129313640@sboyd-linaro>
 <57723FD5.8050305@ti.com>
 <146715129359.31418.3271966598208551482@sboyd-linaro>
CC: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-msm@vger.kernel.org>
From: Roger Quadros <rogerq@ti.com>
Message-ID: <57736671.6090800@ti.com>
Date: Wed, 29 Jun 2016 09:10:57 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <146715129359.31418.3271966598208551482@sboyd-linaro>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 29/06/16 01:01, Stephen Boyd wrote:
> Quoting Roger Quadros (2016-06-28 02:13:57)
>> On 28/06/16 11:47, Stephen Boyd wrote:
>>>
>>> Sorry I must have confused you. There are two modules in the PMIC that
>>> are doing detection here. The charger module is detecting the VBUS event
>>> and this misc module is detecting the ID pin. I'm not sure why they're
>>> two different blocks, but it is what it is in the hardware.
>>>
>> OK. Can the MISC block do anything else other than USB ID?
> 
> Yes.
> 
>> Does the USB ID interrupt come on a different line than the charger interrupt?
> 
> Yes.
> 

OK. Is it better to have this driver somewhere in drivers/mfd or drivers/misc if the
other function doesn't need/use extcon?

>>
>> It would be more like MISC block interrupt than USB ID interrupt right?
> 
> There are two interrupts going to two different hw blocks inside the
> PMIC.
> 

cheers,
-roger