From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752110AbcF2G0D (ORCPT ); Wed, 29 Jun 2016 02:26:03 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:55317 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750790AbcF2G0A (ORCPT ); Wed, 29 Jun 2016 02:26:00 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68e-f79266d000001428-ab-577369f614d8 Content-transfer-encoding: 8BIT Message-id: <577369F5.8040907@samsung.com> Date: Wed, 29 Jun 2016 15:25:57 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Stephen Boyd , Chanwoo Choi Cc: linux-arm-msm@vger.kernel.org, linux-kernel , linux-arm-kernel , Roger Quadros Subject: Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware References: <20160626055647.18898-1-stephen.boyd@linaro.org> <146705470025.30684.13257433085055355379@sboyd-linaro> <146715115921.31418.2315766296233007937@sboyd-linaro> In-reply-to: <146715115921.31418.2315766296233007937@sboyd-linaro> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBIsWRmVeSWpSXmKPExsWyRsSkUPdbZnG4QUcbq8Wzo9oWmx5fY7WY uP8su8XlXXPYLHoeaVnMvXqAyYHNY+esu+wed67tYfPYvKTe4/iN7UwenzfJBbBGcdmkpOZk lqUW6dslcGWc2/6KseArX8XhH01sDYxvuLsYOTkkBEwk+rsPMEHYYhIX7q1n62Lk4hASWMEo 0TT9CgtM0fmLB5kgErMYJRpnvwLr4BUQlPgx+R5QEQcHs4C8xJFL2RCmusSUKbkQ5Q8YJWbe b2eGKNeS2Ll9E9hMFgFViS+LJzOC2GxA8f0vbrCB9IoKREh0n6gEMUUEfCWmXSgHGcMssIpR 4vGaBWBbhQXCJT4vOsUIMb+fWWLms92sIAlOASeJKfvPMIMkJASOsUvs+9PECLFMQOLb5ENg d0oIyEpsOsAM8ZekxMEVN1gmMIrNQvLNLIRvZiF8s4CReRWjaGpBckFxUnqRkV5xYm5xaV66 XnJ+7iZGYISd/vesbwfjzQPWhxgFOBiVeHgtLhSFC7EmlhVX5h5iNAW6YSKzlGhyPjCO80ri DY3NjCxMTUyNjcwtzZTEeROkfgYLCaQnlqRmp6YWpBbFF5XmpBYfYmTi4JRqYBQMWGMmwCTQ v3LeHvHVb74WaTl4HZm2dO2RZbvWJ62T+pbOZnjk9L7XzNVxEzr5ddcLfFmZlDGjiXm649Z9 PGcuBtzP7SqQ/zD18WFVpWk/XG+zJLyOP2SVJvmPQc5kWtPMzJIiqdX/V/BusFnFs4/nZZWM V2yKteg/xUXVKX4RLdcOm+7hzFViKc5INNRiLipOBACC+DQ9qwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCIsWRmVeSWpSXmKPExsVy+t9jQd1vmcXhBp0sFs+OaltsenyN1WLi /rPsFpd3zWGz6HmkZTH36gEmBzaPnbPusnvcubaHzWPzknqP4ze2M3l83iQXwBrVwGiTkZqY klqkkJqXnJ+SmZduq+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA7ReSaEsMacUKBSQ WFyspG+HaUJoiJuuBUxjhK5vSBBcj5EBGkhYw5hxbvsrxoKvfBWHfzSxNTC+4e5i5OSQEDCR OH/xIBOELSZx4d56ti5GLg4hgVmMEo2zX4EleAUEJX5MvsfSxcjBwSwgL3HkUjaEqS4xZUou RPkDRomZ99uZIcq1JHZu38QCYrMIqEp8WTyZEcRmA4rvf3GDDaRXVCBCovtEJYgpIuArMe1C OcgYZoFVjBKP1ywA2yosEC7xedEpRoj5/cwSM5/tZgVJcAo4SUzZf4Z5AiPQkQjXzUK4bhbC dQsYmYFmphYkFxQnpeca5aWW6xUn5haX5qXrJefnbmIEx/Az6R2Mh3e5H2IU4GBU4uG1uFAU LsSaWFZcmXuIUYKDWUmEtyC1OFyINyWxsiq1KD++qDQntfgQoynQexOZpUST84HpJa8k3tDY xMzI0sjc0MLI2FxJnPfx/3VhQgLpiSWp2ampBalFMH1MHJxSDYwuu6rbDwZ2Bp0w/fgmZEr7 I00r3k9fp6mtaYuadH/1RoUnkoLCXbzl5nd1wt/lvfK88din9Yav8Z6m0Nt/r6zjXezNu3cW yyYh66OLD1nXBSyW836+4vDNd5W/w812XiqRDvjFOvWw1ZUunmsr2ITtDH7e3W+8MU29rrRf 7+fSpV0W7V5nJmoqsRRnJBpqMRcVJwIA+sITNfcCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 06월 29일 06:59, Stephen Boyd wrote: > Quoting Chanwoo Choi (2016-06-28 05:06:48) >> 2016-06-28 4:11 GMT+09:00 Stephen Boyd : >>> Quoting Chanwoo Choi (2016-06-26 04:20:43) >>>> 2016-06-26 14:56 GMT+09:00 Stephen Boyd : >>>>> +PROPERTIES >>>>> + >>>>> +- compatible: >>>>> + Usage: required >>>>> + Value type: >>>>> + Definition: Should contain "qcom,pm8941-misc"; >>>>> + >>>>> +- reg: >>>>> + Usage: required >>>>> + Value type: >>>>> + Definition: Should contain the offset to the misc address space >>>> >>>> 'reg' property is used on extcon-qcom-spmi-misc.c? >>>> I think that you don't need to include this property. >>> >>> No it isn't used in the driver right now, but there is a register offset >>> for this module and there are registers that can be read/written in this >>> module. I'd like to keep it as required so we can easily read the >>> registers in the future if needed. >> >> OK. >> But, If you want to remain the reg property, you should add the code to get >> the register offset by using OF functions. This patch don't include the OF >> function to handle it. >> > > Sorry I don't follow the argument. I've put the reg property here for > future proofing so that the binding doesn't have to change in backwards > incompatible ways in the future if we do need to get the property later. I don't mention that 'reg' property should be removed. Just if you want to remain it, you should add some codes as following: For exmaple, - of_get_address() to get the address information from device-tree. If documentation include the some properties, you should add the handling code in device driver. When you add the code to get the offset from device-tree, it doesn't influence the some behavior in the future. Thanks, Chanwoo Choi