From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752625AbcF2Mmk (ORCPT ); Wed, 29 Jun 2016 08:42:40 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:55414 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751767AbcF2Mmj (ORCPT ); Wed, 29 Jun 2016 08:42:39 -0400 X-IronPort-AV: E=Sophos;i="5.26,546,1459814400"; d="scan'208";a="370345977" Subject: Re: [Xen-devel] [PATCH v2 2/2] xen-pciback: clean up {bar, rom}_init() To: Jan Beulich , David Vrabel , Boris Ostrovsky References: <5756857802000078000F268D@prv-mh.provo.novell.com> <5756866F02000078000F269D@prv-mh.provo.novell.com> <576D4B59.9070906@citrix.com> <5770F0CF02000078000F8DD3@prv-mh.provo.novell.com> CC: Juergen Gross , xen-devel , From: David Vrabel Message-ID: <5773C239.1040005@citrix.com> Date: Wed, 29 Jun 2016 13:42:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <5770F0CF02000078000F8DD3@prv-mh.provo.novell.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/06/16 08:24, Jan Beulich wrote: >>>> On 24.06.16 at 17:01, wrote: >> On 07/06/16 07:31, Jan Beulich wrote: >>> - drop unused function parameter of read_dev_bar() >>> - drop rom_init() (now identical to bar_init()) >>> - fold read_dev_bar() into its now single caller >>> - simplify determination of 64-bit memory resource >>> - use const and unsigned >> >> Please split this in 5 separate patches for easier review. >> >> Especially as often anyone writing "simplify" means "accidentally break". > > So this is directly opposite of what Boris had asked for - originally > there were two patches, which I folded upon his request (and > which he gave his R-b for already). May I ask the two of you to > first settle on a consistent set of expectations to patches like this? SubmittingPatches section 3 is clear on what is required. If your commit message is a list of bullet points it's a pretty big hint that none of the changes are related. David