From: David Vrabel <david.vrabel@citrix.com>
To: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
David Vrabel <david.vrabel@citrix.com>,
"Juergen Gross" <jgross@suse.com>
Cc: Tejun Heo <tj@kernel.org>, <xen-devel@lists.xenproject.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH v2] xen: xenbus: Remove create_workqueue
Date: Wed, 29 Jun 2016 13:50:14 +0100 [thread overview]
Message-ID: <5773C406.5020508@citrix.com> (raw)
In-Reply-To: <20160531165630.GA21779@Karyakshetra>
On 31/05/16 17:56, Bhaktipriya Shridhar wrote:
> System workqueues have been able to handle high level of concurrency
> for a long time now and there's no reason to use dedicated workqueues
> just to gain concurrency. Replace dedicated xenbus_frontend_wq with the
> use of system_wq.
>
> Unlike a dedicated per-cpu workqueue created with create_workqueue(),
> system_wq allows multiple work items to overlap executions even on
> the same CPU; however, a per-cpu workqueue doesn't have any CPU
> locality or global ordering guarantees unless the target CPU is
> explicitly specified and the increase of local concurrency shouldn't
> make any difference.
>
> In this case, there is only a single work item, increase of concurrency
> level by switching to system_wq should not make any difference.
Applied to for-linus-4.8, thanks.
David
prev parent reply other threads:[~2016-06-29 12:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 16:56 [PATCH v2] xen: xenbus: Remove create_workqueue Bhaktipriya Shridhar
2016-05-31 17:29 ` Tejun Heo
2016-06-28 16:47 ` Bhaktipriya Shridhar
2016-06-29 12:50 ` David Vrabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5773C406.5020508@citrix.com \
--to=david.vrabel@citrix.com \
--cc=bhaktipriya96@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox