From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752672AbcF2MuX (ORCPT ); Wed, 29 Jun 2016 08:50:23 -0400 Received: from smtp.citrix.com ([66.165.176.89]:41789 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752432AbcF2MuV (ORCPT ); Wed, 29 Jun 2016 08:50:21 -0400 X-IronPort-AV: E=Sophos;i="5.26,546,1459814400"; d="scan'208";a="363449072" Subject: Re: [Xen-devel] [PATCH v2] xen: xenbus: Remove create_workqueue To: Bhaktipriya Shridhar , Boris Ostrovsky , David Vrabel , "Juergen Gross" References: <20160531165630.GA21779@Karyakshetra> CC: Tejun Heo , , From: David Vrabel Message-ID: <5773C406.5020508@citrix.com> Date: Wed, 29 Jun 2016 13:50:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160531165630.GA21779@Karyakshetra> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/05/16 17:56, Bhaktipriya Shridhar wrote: > System workqueues have been able to handle high level of concurrency > for a long time now and there's no reason to use dedicated workqueues > just to gain concurrency. Replace dedicated xenbus_frontend_wq with the > use of system_wq. > > Unlike a dedicated per-cpu workqueue created with create_workqueue(), > system_wq allows multiple work items to overlap executions even on > the same CPU; however, a per-cpu workqueue doesn't have any CPU > locality or global ordering guarantees unless the target CPU is > explicitly specified and the increase of local concurrency shouldn't > make any difference. > > In this case, there is only a single work item, increase of concurrency > level by switching to system_wq should not make any difference. Applied to for-linus-4.8, thanks. David