From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752814AbcF2ORl (ORCPT ); Wed, 29 Jun 2016 10:17:41 -0400 Received: from smtp.nue.novell.com ([195.135.221.5]:52307 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752413AbcF2ORk (ORCPT ); Wed, 29 Jun 2016 10:17:40 -0400 Subject: Re: [PATCH 06/11] staging: fsl-mc: make fsl_mc_is_root_dprc() global To: Stuart Yoder , gregkh@linuxfoundation.org References: <1466631652-25731-1-git-send-email-stuart.yoder@nxp.com> <1466631652-25731-7-git-send-email-stuart.yoder@nxp.com> Cc: devel@driverdev.osuosl.org, agraf@suse.de, arnd@arndb.de, german.rivera@nxp.com, linux-kernel@vger.kernel.org, leoyang.li@nxp.com From: Matthias Brugger Message-ID: <5773D877.1040005@suse.com> Date: Wed, 29 Jun 2016 16:17:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <1466631652-25731-7-git-send-email-stuart.yoder@nxp.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/06/16 23:40, Stuart Yoder wrote: > make fsl_mc_is_root_dprc() global so that the dprc driver > can use it > > Signed-off-by: Stuart Yoder > --- > drivers/staging/fsl-mc/bus/mc-bus.c | 28 +++++++++++++--------------- > drivers/staging/fsl-mc/include/mc.h | 2 ++ > 2 files changed, 15 insertions(+), 15 deletions(-) > > diff --git a/drivers/staging/fsl-mc/bus/mc-bus.c b/drivers/staging/fsl-mc/bus/mc-bus.c > index e975adc..a49186e 100644 > --- a/drivers/staging/fsl-mc/bus/mc-bus.c > +++ b/drivers/staging/fsl-mc/bus/mc-bus.c > @@ -24,8 +24,6 @@ > > static struct kmem_cache *mc_dev_cache; > > -static bool fsl_mc_is_root_dprc(struct device *dev); > - > /** > * fsl_mc_bus_match - device to driver matching callback > * @dev: the MC object device structure to match against > @@ -247,19 +245,6 @@ static void fsl_mc_get_root_dprc(struct device *dev, > } > } > > -/** > - * fsl_mc_is_root_dprc - function to check if a given device is a root dprc > - */ > -static bool fsl_mc_is_root_dprc(struct device *dev) > -{ > - struct device *root_dprc_dev; > - > - fsl_mc_get_root_dprc(dev, &root_dprc_dev); > - if (!root_dprc_dev) > - return false; > - return dev == root_dprc_dev; > -} > - > static int get_dprc_attr(struct fsl_mc_io *mc_io, > int container_id, struct dprc_attributes *attr) > { > @@ -424,6 +409,19 @@ error_cleanup_regions: > } > > /** > + * fsl_mc_is_root_dprc - function to check if a given device is a root dprc > + */ > +bool fsl_mc_is_root_dprc(struct device *dev) > +{ > + struct device *root_dprc_dev; > + > + fsl_mc_get_root_dprc(dev, &root_dprc_dev); > + if (!root_dprc_dev) > + return false; > + return dev == root_dprc_dev; > +} > + > +/** Is there any reason why apart from deleting "static" you move fsl_mc_is_root to a different line? Regards, Matthias > * Add a newly discovered MC object device to be visible in Linux > */ > int fsl_mc_device_add(struct dprc_obj_desc *obj_desc, > diff --git a/drivers/staging/fsl-mc/include/mc.h b/drivers/staging/fsl-mc/include/mc.h > index a9a9d23..853cbf3 100644 > --- a/drivers/staging/fsl-mc/include/mc.h > +++ b/drivers/staging/fsl-mc/include/mc.h > @@ -207,6 +207,8 @@ int __must_check fsl_mc_allocate_irqs(struct fsl_mc_device *mc_dev); > > void fsl_mc_free_irqs(struct fsl_mc_device *mc_dev); > > +bool fsl_mc_is_root_dprc(struct device *dev); > + > extern struct bus_type fsl_mc_bus_type; > > #endif /* _FSL_MC_H_ */ >