From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <JBeulich@suse.com>,
Amitoj Kaur Chawla <amitoj1606@gmail.com>
Cc: david.vrabel@citrix.com, x86@kernel.org, tglx@linutronix.de,
julia.lawall@lip6.fr, xen-devel@lists.xenproject.org,
boris.ostrovsky@oracle.com, mingo@redhat.com,
linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: [Xen-devel] [PATCH] x86/xen: Use DIV_ROUND_UP
Date: Wed, 29 Jun 2016 17:35:58 +0200 [thread overview]
Message-ID: <5773EADE.70600@suse.com> (raw)
In-Reply-To: <5774068C02000078000F9DCB@suse.com>
On 29/06/16 17:34, Jan Beulich wrote:
>>>> On 29.06.16 at 17:00, <amitoj1606@gmail.com> wrote:
>> --- a/arch/x86/xen/enlighten.c
>> +++ b/arch/x86/xen/enlighten.c
>> @@ -591,7 +591,7 @@ static void xen_load_gdt(const struct desc_ptr *dtr)
>> {
>> unsigned long va = dtr->address;
>> unsigned int size = dtr->size + 1;
>> - unsigned pages = (size + PAGE_SIZE - 1) / PAGE_SIZE;
>> + unsigned pages = DIV_ROUND_UP(size, PAGE_SIZE);
>> unsigned long frames[pages];
>> int f;
>>
>> @@ -640,7 +640,7 @@ static void __init xen_load_gdt_boot(const struct desc_ptr *dtr)
>> {
>> unsigned long va = dtr->address;
>> unsigned int size = dtr->size + 1;
>> - unsigned pages = (size + PAGE_SIZE - 1) / PAGE_SIZE;
>> + unsigned pages = DIV_ROUND_UP(size, PAGE_SIZE);
>> unsigned long frames[pages];
>> int f;
>>
>
> Perhaps even more readable would be PFN_DOWN()?
Or PFN_UP() to be correct?
Juergen
next prev parent reply other threads:[~2016-06-29 15:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 15:00 [PATCH] x86/xen: Use DIV_ROUND_UP Amitoj Kaur Chawla
2016-06-29 15:34 ` [Xen-devel] " Jan Beulich
[not found] ` <5774068C02000078000F9DCB@suse.com>
2016-06-29 15:35 ` Juergen Gross [this message]
2016-06-29 15:45 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5773EADE.70600@suse.com \
--to=jgross@suse.com \
--cc=JBeulich@suse.com \
--cc=amitoj1606@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).