From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752579AbcF2PhT (ORCPT ); Wed, 29 Jun 2016 11:37:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:50793 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752082AbcF2PhR (ORCPT ); Wed, 29 Jun 2016 11:37:17 -0400 Subject: Re: [Xen-devel] [PATCH] x86/xen: Use DIV_ROUND_UP To: Jan Beulich , Amitoj Kaur Chawla References: <20160629150038.GA13956@amitoj-Inspiron-3542> <5774068C02000078000F9DCB@suse.com> Cc: david.vrabel@citrix.com, x86@kernel.org, tglx@linutronix.de, julia.lawall@lip6.fr, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, mingo@redhat.com, linux-kernel@vger.kernel.org, hpa@zytor.com From: Juergen Gross Message-ID: <5773EADE.70600@suse.com> Date: Wed, 29 Jun 2016 17:35:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <5774068C02000078000F9DCB@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/06/16 17:34, Jan Beulich wrote: >>>> On 29.06.16 at 17:00, wrote: >> --- a/arch/x86/xen/enlighten.c >> +++ b/arch/x86/xen/enlighten.c >> @@ -591,7 +591,7 @@ static void xen_load_gdt(const struct desc_ptr *dtr) >> { >> unsigned long va = dtr->address; >> unsigned int size = dtr->size + 1; >> - unsigned pages = (size + PAGE_SIZE - 1) / PAGE_SIZE; >> + unsigned pages = DIV_ROUND_UP(size, PAGE_SIZE); >> unsigned long frames[pages]; >> int f; >> >> @@ -640,7 +640,7 @@ static void __init xen_load_gdt_boot(const struct desc_ptr *dtr) >> { >> unsigned long va = dtr->address; >> unsigned int size = dtr->size + 1; >> - unsigned pages = (size + PAGE_SIZE - 1) / PAGE_SIZE; >> + unsigned pages = DIV_ROUND_UP(size, PAGE_SIZE); >> unsigned long frames[pages]; >> int f; >> > > Perhaps even more readable would be PFN_DOWN()? Or PFN_UP() to be correct? Juergen