From: David Vrabel <david.vrabel@citrix.com>
To: Amitoj Kaur Chawla <amitoj1606@gmail.com>,
<boris.ostrovsky@oracle.com>, <david.vrabel@citrix.com>,
<jgross@suse.com>, <tglx@linutronix.de>, <mingo@redhat.com>,
<hpa@zytor.com>, <x86@kernel.org>,
<xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>
Cc: <julia.lawall@lip6.fr>
Subject: Re: [Xen-devel] [PATCH] x86/xen: Use DIV_ROUND_UP
Date: Wed, 29 Jun 2016 16:45:00 +0100 [thread overview]
Message-ID: <5773ECFC.3000407@citrix.com> (raw)
In-Reply-To: <20160629150038.GA13956@amitoj-Inspiron-3542>
On 29/06/16 16:00, Amitoj Kaur Chawla wrote:
> The kernel.h macro DIV_ROUND_UP performs the computation
> (((n) + (d) - 1) /(d)) but is perhaps more readable.
>
> The Coccinelle script used to make this change is as follows:
> @haskernel@
> @@
>
> #include <linux/kernel.h>
>
> @depends on haskernel@
> expression n,d;
> @@
>
> (
> - (n + d - 1) / d
> + DIV_ROUND_UP(n,d)
> |
> - (n + (d - 1)) / d
> + DIV_ROUND_UP(n,d)
> )
Applied to for-linus-4.8, thanks.
PFN_UP/DOWN() are for converting addresses to PFNs. DIV_ROUND_UP() is
clearer when converting sizes to numbers of pages (as demonstrated by
the incorrect suggestion to use PFN_DOWN()).
David
prev parent reply other threads:[~2016-06-29 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 15:00 [PATCH] x86/xen: Use DIV_ROUND_UP Amitoj Kaur Chawla
2016-06-29 15:34 ` [Xen-devel] " Jan Beulich
[not found] ` <5774068C02000078000F9DCB@suse.com>
2016-06-29 15:35 ` Juergen Gross
2016-06-29 15:45 ` David Vrabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5773ECFC.3000407@citrix.com \
--to=david.vrabel@citrix.com \
--cc=amitoj1606@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).