From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752382AbcF2SKj (ORCPT ); Wed, 29 Jun 2016 14:10:39 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:53420 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752207AbcF2SKg (ORCPT ); Wed, 29 Jun 2016 14:10:36 -0400 Subject: Re: [PATCH] power: qcom-smbb: add extcon dependency To: Sebastian Reichel , Arnd Bergmann References: <20160629143056.7405-1-arnd@arndb.de> <20160629143803.GA28325@earth> Cc: Dmitry Eremin-Solenikov , David Woodhouse , Courtney Cavin , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org From: Stephen Boyd Message-ID: <57740F1A.5040007@codeaurora.org> Date: Wed, 29 Jun 2016 11:10:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160629143803.GA28325@earth> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/29/2016 07:38 AM, Sebastian Reichel wrote: > Hi, > > On Wed, Jun 29, 2016 at 04:30:02PM +0200, Arnd Bergmann wrote: >> Building the smbb driver without extcon results in a link failure: >> >> drivers/power/built-in.o: In function `smbb_usb_valid_handler': >> :(.text+0x3190): undefined reference to `extcon_set_cable_state_' >> drivers/power/built-in.o: In function `smbb_charger_probe': >> :(.text+0x3880): undefined reference to `devm_extcon_dev_allocate' >> :(.text+0x3898): undefined reference to `devm_extcon_dev_register' >> >> This adds a Kconfig dependency. >> >> Signed-off-by: Arnd Bergmann >> Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver") extcon use was only recently introduced so this should be Fixes: 0b7fe26ae602 ("power: qcom_smbb: Make an extcon for usb cable detection") -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project